Use < instead of = in case benchmark predicates, use Integers #18144
+39
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 18, 2025
| // Many when/then branches where all but the first few are effectively unreachable | ||
| c.bench_function(format!("case_when {}x{}: CASE WHEN c1 < 0 THEN 0 WHEN c1 < 1000 THEN 1 ... WHEN c1 < n * 1000 THEN n ELSE n + 1 END", batch.num_rows(), batch.num_columns()).as_str(), |b| { | ||
| let when_thens = (0..batch.num_rows() as i32).map(|i| (make_x_cmp_y(&c1, Operator::Eq, i * 1000), lit(i))).collect(); | ||
| let when_thens = (0..batch.num_rows() as i32).map(|i| (make_x_cmp_y(&c1, Operator::Lt, i * 1000), lit(i))).collect(); |
There was a problem hiding this comment.
sorry I missed this in the initial review
There was a problem hiding this comment.
That's perfectly understandable. With the sheer number of PRs you're reviewing it's easy to miss something small like this.
I was focusing (or trying to at least) on this and missed the copy/paste mistake myself as author. It only became apparent when the unexpected results showed up.
Clearly trying to do too many things at the same time.
There was a problem hiding this comment.
Clearly trying to do too many things at the same time.
Indeed -- story of my (current) life!
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The last benchmark was incorrectly essentially indentical to the second to last one. The actual predicate was using
=instead of<.What changes are included in this PR?
<case x when ...Are these changes tested?
Verified with debugger.
Are there any user-facing changes?
No