Don't Canonicalize Filesystem Paths in ListingTableUrl / support new external tables for files that do not (yet) exist #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
changed the title
|
This is currently blocked on apache/arrow-rs#5019 |
tustvold
force-pushed
the
listing-table-canonicalize
branch
from
62d4c9b to
3ca6aaa
Compare
tustvold
force-pushed
the
listing-table-canonicalize
branch
from
3ca6aaa to
097131c
Compare
tustvold
commented
Nov 18, 2023
| @@ -388,15 +388,7 @@ mod tests { | |||
| // Ensure that local files are also registered | |||
| let sql = | |||
| format!("CREATE EXTERNAL TABLE test STORED AS PARQUET LOCATION '{location}'"); | |||
| let err = create_external_table_test(location, &sql) | |||
There was a problem hiding this comment.
This no longer generates an error as we don't require that the path exists
There was a problem hiding this comment.
I swear there is a ticket that tracks this, but I couldn't find it. Thus I filed #8277 and updated this PR to close it
This was referenced Nov 20, 2023
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8277
Rationale for this change
Split out from #8007 and building on top of #8012. Instead of canonicalizing the path before conversion to a URL, it instead concatenates the working directory and relies on the URL crate's built in path resolution logic to reconcile relative paths. This allows creating ListingTableUrl to paths that don't currently exist.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Users can now create external tables referencing path that don't (yet) exist