Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extract array_to_string and string_to_array from functions-array subcrate' s kernels and udf containers #9704

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

erenavsarogullari
Copy link
Member

@erenavsarogullari erenavsarogullari commented Mar 20, 2024

Which issue does this PR close?

Closes #9660.

What changes are included in this PR?

This PR aims to do following refactoring:
1- Extracts array_to_string and string_to_array functions from functions-array subcrate' s kernels and udf containers,
2- to_string and call_array_function macro_rules are being moved to string.rs,
3- downcast_arg macro_rule is being moved to util.rs,
4- make_scalar_function is applied to ArrayToString.invoke and StringToArray.invoke functions,
5- StringToArray.invoke function is refactored slightly,
Note: I preferred to submit this partial changeset for the review in order to avoid big-bang.

Are these changes tested?

Yes, all array.slt based array_to_string and string_to_array functions tests are passed.

Are there any user-facing changes?

No

@erenavsarogullari erenavsarogullari changed the title refactor: Extract array_to_string and string_to_array from kernels and udf containers refactor: Extract array_to_string and string_to_array from functions-array subcrate' s kernels and udf containers Mar 20, 2024
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks @erenavsarogullari

@alamb
Copy link
Contributor

alamb commented Mar 20, 2024

Note: I preferred to submit this partial changeset for the review in order to avoid big-bang.

THank you 🙏

@alamb alamb merged commit 3bf06d3 into apache:main Mar 20, 2024
23 checks passed
@erenavsarogullari erenavsarogullari deleted the Issue-9660 branch March 21, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break-down functions-array subcreate' s kernels and udf containers
3 participants