refactor: Extract array_to_string
and string_to_array
from functions-array
subcrate' s kernels
and udf
containers
#9704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9660.
What changes are included in this PR?
This PR aims to do following refactoring:
1- Extracts
array_to_string
andstring_to_array
functions fromfunctions-array
subcrate' skernels
andudf
containers,2-
to_string
andcall_array_function
macro_rules
are being moved tostring.rs
,3-
downcast_arg
macro_rule
is being moved toutil.rs
,4-
make_scalar_function
is applied toArrayToString.invoke
andStringToArray.invoke
functions,5-
StringToArray.invoke
function is refactored slightly,Note: I preferred to submit this partial changeset for the review in order to avoid big-bang.
Are these changes tested?
Yes, all
array.slt
basedarray_to_string
andstring_to_array
functions tests are passed.Are there any user-facing changes?
No