-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose parser
on DFParser to enable user controlled parsing
#9729
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
134b232
poc: custom parser
tshauck bd8e52a
play with extension statement
tshauck 97916e4
tweak
tshauck 4b59f18
Revert "tweak"
tshauck 362e5af
Revert "play with extension statement"
tshauck 1b966e3
style: cargo fmt
tshauck f0f5c67
Update datafusion-examples/examples/sql_parsing.rs
tshauck ecf6c59
Apply suggestions from code review
tshauck dc871ed
style: cargo cmt
tshauck dc8bed5
refactor: less nesting in parse statement
tshauck 68d54ad
docs: better example description
tshauck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
use std::fmt::Display; | ||
|
||
use datafusion::error::Result; | ||
use datafusion_sql::{ | ||
parser::{CopyToSource, CopyToStatement, DFParser, Statement}, | ||
sqlparser::{keywords::Keyword, parser::ParserError, tokenizer::Token}, | ||
}; | ||
|
||
/// This example demonstrates how to use the DFParser to parse a statement in a custom way | ||
/// | ||
/// This technique can be used to implement a custom SQL dialect, for example. | ||
#[tokio::main] | ||
async fn main() -> Result<()> { | ||
let mut my_parser = | ||
MyParser::new("COPY source_table TO 'file.fasta' STORED AS FASTA")?; | ||
|
||
let my_statement = my_parser.parse_statement()?; | ||
|
||
match my_statement { | ||
MyStatement::DFStatement(s) => println!("df: {}", s), | ||
MyStatement::MyCopyTo(s) => println!("my_copy: {}", s), | ||
} | ||
|
||
Ok(()) | ||
} | ||
|
||
/// Here we define a Parser for our new SQL dialect that wraps the existing `DFParser` | ||
struct MyParser<'a> { | ||
df_parser: DFParser<'a>, | ||
} | ||
|
||
impl MyParser<'_> { | ||
fn new(sql: &str) -> Result<Self> { | ||
let df_parser = DFParser::new(sql)?; | ||
Ok(Self { df_parser }) | ||
} | ||
|
||
/// Returns true if the next token is `COPY` keyword, false otherwise | ||
fn is_copy(&self) -> bool { | ||
matches!( | ||
self.df_parser.parser.peek_token().token, | ||
Token::Word(w) if w.keyword == Keyword::COPY | ||
) | ||
} | ||
|
||
/// This is the entry point to our parser -- it handles `COPY` statements specially | ||
/// but otherwise delegates to the existing DataFusion parser. | ||
pub fn parse_statement(&mut self) -> Result<MyStatement, ParserError> { | ||
if self.is_copy() { | ||
self.df_parser.parser.next_token(); // COPY | ||
let df_statement = self.df_parser.parse_copy()?; | ||
|
||
if let Statement::CopyTo(s) = df_statement { | ||
Ok(MyStatement::from(s)) | ||
} else { | ||
Ok(MyStatement::DFStatement(Box::from(df_statement))) | ||
} | ||
} else { | ||
let df_statement = self.df_parser.parse_statement()?; | ||
Ok(MyStatement::from(df_statement)) | ||
} | ||
} | ||
} | ||
|
||
enum MyStatement { | ||
DFStatement(Box<Statement>), | ||
MyCopyTo(MyCopyToStatement), | ||
} | ||
|
||
impl Display for MyStatement { | ||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
match self { | ||
MyStatement::DFStatement(s) => write!(f, "{}", s), | ||
MyStatement::MyCopyTo(s) => write!(f, "{}", s), | ||
} | ||
} | ||
} | ||
|
||
impl From<Statement> for MyStatement { | ||
fn from(s: Statement) -> Self { | ||
Self::DFStatement(Box::from(s)) | ||
} | ||
} | ||
|
||
impl From<CopyToStatement> for MyStatement { | ||
fn from(s: CopyToStatement) -> Self { | ||
if s.stored_as == Some("FASTA".to_string()) { | ||
Self::MyCopyTo(MyCopyToStatement::from(s)) | ||
} else { | ||
Self::DFStatement(Box::from(Statement::CopyTo(s))) | ||
} | ||
} | ||
} | ||
|
||
struct MyCopyToStatement { | ||
pub source: CopyToSource, | ||
pub target: String, | ||
} | ||
|
||
impl From<CopyToStatement> for MyCopyToStatement { | ||
fn from(s: CopyToStatement) -> Self { | ||
Self { | ||
source: s.source, | ||
target: s.target, | ||
} | ||
} | ||
} | ||
|
||
impl Display for MyCopyToStatement { | ||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
write!( | ||
f, | ||
"COPY {} TO '{}' STORED AS FASTA", | ||
self.source, self.target | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ -- very nice drive by cleanup 🙏