Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Registry][WIP] Connecting to the ZooKeeper with SSL&ACL #16271

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Jul 4, 2024

Purpose of the pull request

fix: Feature

Brief change log

add x509 authinfo for zk registry

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
48.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the pull-request notice. And add some docs and UT to it.


final String x509SubjectPrincipal = properties.getX509SubjectPrincipal();
if (!Strings.isNullOrEmpty(x509SubjectPrincipal)) {
builder.authorization("x509", digest.getBytes(StandardCharsets.UTF_8))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extract x509 to Constans.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add an authorization property and use the key/value provided by users

authorization:
   key: value

@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 4, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jul 4, 2024
@github-actions github-actions bot added the test label Jul 4, 2024
@pegasas pegasas marked this pull request as draft July 4, 2024 09:57
@pegasas pegasas changed the title [Feature][Registry] Connecting to the ZooKeeper with SSL&ACL [Feature][Registry][WIP] Connecting to the ZooKeeper with SSL&ACL Jul 4, 2024
@SbloodyS SbloodyS removed this from the 3.3.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document improvement make more easy to user or prompt friendly test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants