Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16942] Fix global master failover might cause master dead #16953

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

close #16942

Brief change log

  • When we do global master failover, we set the failoveredNodePath with uknonw, avoid the master failover it self will cause it stop
  • We use failoverDeadline as the failoveredNodePath's value to avoid duplicate failovered.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@SbloodyS SbloodyS added the bug Something isn't working label Jan 10, 2025
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jan 10, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@caishunfeng caishunfeng changed the title [Fix-16942] Fix gloval master failover might cause master dead [Fix-16942] Fix global master failover might cause master dead Jan 10, 2025
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit b6b0461 into apache:dev Jan 10, 2025
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [MasterHeartBeatTask] master will stop after completed the failover process
3 participants