Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-16992][dolphinscheduler-task-seatunnel] Implement added seatunnel configuration generation in the form mode #16993

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

JeremyXin
Copy link

@JeremyXin JeremyXin commented Feb 2, 2025

Purpose of the pull request

Implement added seatunnel configuration generation in the form mode.
Try to implement issues #16992.
Full ideas and front and backend effection picture can be found in the pdf file below.
DolphinScheduler Seatunnel plugin form configuration scheme.pdf

If you have any questions, please contact me in time. Thank you for your review!

close #16992

Brief change log

Modify the front and backend code of the dolphinscheduler-task-seatunnel plugin

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:
SeatunnelTaskTest.testSeatunnelConfigGeneration() method.

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

…unnel configuration generation in the form mode
Copy link

boring-cyborg bot commented Feb 2, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@github-actions github-actions bot added UI ui and front end related backend test labels Feb 2, 2025
@SbloodyS SbloodyS added first time contributor First-time contributor feature new feature labels Feb 2, 2025
@SbloodyS SbloodyS added this to the 3.3.0 milestone Feb 2, 2025
@SbloodyS
Copy link
Member

SbloodyS commented Feb 2, 2025

Hi @JeremyXin , thanks for your contribution. Can you copy and paste the contents of the pdf into the description with english, which will make it easier for others to participate in the discussion and review?


String seatunnelConfig = envConfig + "\n" + sourceConfig + "\n" + transformConfig + "\n" + sinkConfig;

log.info("Generate Seatunnel Config => \n{}", seatunnelConfig);

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files High

This
potentially sensitive information
is written to a log file.
@JeremyXin
Copy link
Author

Hi @JeremyXin , thanks for your contribution. Can you copy and paste the contents of the pdf into the description with english, which will make it easier for others to participate in the discussion and review?

Ok,I have updated the English version of the document and optimized the code. Thank you for your reply.

@JeremyXin
Copy link
Author

How can I retry analysis of this Pull-Request directly on SonarQube Cloud?

@davidzollo
Copy link
Contributor

davidzollo commented Feb 11, 2025

How can I retry analysis of this Pull-Request directly on SonarQube Cloud?

to First-time contributor, it need to trigger CI by committer manually

@JeremyXin
Copy link
Author

I have added unit test code to improve coverage on new code and may need to re-execute SonarQube Cloud. Thanks!

@SbloodyS SbloodyS requested a review from ruanwenjun February 11, 2025 08:20
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature new feature first time contributor First-time contributor test UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][dolphinscheduler-task-seatunnel] Added seatunnel configuration generation in the form mode
3 participants