[fateure](stream-load) Added direct load via BENODE #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNSimba
reviewed
Dec 8, 2023
| @@ -98,6 +98,8 @@ public class DorisStreamLoad implements Serializable { | |||
| private static final long cacheExpireTimeout = 4 * 60; | |||
| private final LoadingCache<String, List<BackendV2.BackendRowV2>> cache; | |||
| private final String fenodes; | |||
| //添加BENODES | |||
There was a problem hiding this comment.
Ok , let me delete that
JNSimba
reviewed
Dec 8, 2023
Comment on lines
417
to
415
| if (autoRedirect && null == beNodes) { | ||
| return RestService.randomEndpoint(fenodes, LOG); |
There was a problem hiding this comment.
Is it possible to use autoRedirect directly to judge here? There is no need to add benodes=null logic, otherwise the configuration will be confusing.
There was a problem hiding this comment.
ok let me think about this one
JNSimba
reviewed
Dec 8, 2023
| import static org.apache.doris.spark.cfg.ConfigurationOptions.DORIS_TABLET_SIZE_DEFAULT; | ||
| import static org.apache.doris.spark.cfg.ConfigurationOptions.DORIS_TABLET_SIZE_MIN; | ||
| import static org.apache.doris.spark.cfg.ConfigurationOptions.DORIS_TABLE_IDENTIFIER; | ||
| import static org.apache.doris.spark.cfg.ConfigurationOptions.*; |
MYiYang
force-pushed
the
feature-yangmuyi-beNodes
branch
from
5588b7a to
3c723a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes