-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](metrics) Unify metrics of thread pool #43144
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TeamCity be ut coverage result: |
run buildall |
run buildall |
1 similar comment
run buildall |
TeamCity be ut coverage result: |
run buildall |
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
7eb8642
to
5928144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
5928144
to
2a36bd5
Compare
run buildall |
run buildall |
run buildall |
1 similar comment
run buildall |
run buildall |
TPC-H: Total hot run time: 33416 ms
|
TPC-DS: Total hot run time: 196400 ms
|
ClickBench: Total hot run time: 30.99 s
|
run buildall |
TPC-H: Total hot run time: 32530 ms
|
TPC-DS: Total hot run time: 190511 ms
|
ClickBench: Total hot run time: 31.93 s
|
run buildall |
TPC-H: Total hot run time: 32784 ms
|
TPC-DS: Total hot run time: 190743 ms
|
ClickBench: Total hot run time: 31.6 s
|
run buildall |
TPC-H: Total hot run time: 32577 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 196422 ms
|
ClickBench: Total hot run time: 30.76 s
|
run buildall |
TPC-H: Total hot run time: 32455 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 195902 ms
|
ClickBench: Total hot run time: 31.28 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Add metrics for all thread pool, more specifically, for all ThreadPool objects.
All thread pool will have following metrics:
A new class
IntervalHistogramStat
is created for interval histogram calculation.Metrics is updated by
hook
method when they are needed by prometheus.Check List (For Committer)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)