Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](cloud) Fix replay default compute group failed throw exception #43766 #43889

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #43766

…43766)

### What problem does this PR solve?

due to #42504, replay thread will check default compute group auth, if
failed will throw exception, lead to fe can't start

```
2024-11-12 06:49:46,432 ERROR (stateListener|14) [EditLog.loadJournal():1248] replay Operation Type 69, log id: 1124
org.apache.doris.cloud.qe.ComputeGroupException: errCode = 2, detailMessage = set default compute group failed, user regression_test_cloud_user2 has no permission to use compute group 'smoke_test_cluster_01', please grant use privilege first , ComputeGroupException: CURRENT_USER_NO_AUTH_TO_USE_COMPUTE_GROUP, you canuse SQL `GRANT USAGE_PRIV ON COMPUTE GROUP {compute_group_name} TO {user}`
        at org.apache.doris.mysql.privilege.UserProperty.checkCloudDefaultCluster(UserProperty.java:398) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.mysql.privilege.UserProperty.update(UserProperty.java:263) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.mysql.privilege.UserPropertyMgr.updateUserProperty(UserPropertyMgr.java:91) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.mysql.privilege.Auth.updateUserPropertyInternal(Auth.java:1084) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.mysql.privilege.Auth.replayUpdateUserProperty(Auth.java:1077) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:505) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.replayJournal(Env.java:2962) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.transferToMaster(Env.java:1552) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.access$1200(Env.java:345) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2841) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT]
```

fix:
ignore check default compute group auth when isReplay eq true

Issue Number: close #xxx

Related PR: #42504
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

run buildall

@gavinchou gavinchou closed this Nov 13, 2024
@gavinchou gavinchou reopened this Nov 13, 2024
@gavinchou gavinchou merged commit a21b017 into branch-3.0 Nov 14, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants