-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](variant) fix index in variant (#43375) #43971
base: branch-2.1
Are you sure you want to change the base?
Conversation
Problem Summary: 1. Fixing error checks, `InvertedIndexColumnWriter::check_support_inverted_index`, It is not appropriate to determine support for other indexes by checking the inverted index. 2. Fix `TableSchema::update_index()` Co-authored-by: csun5285 <[email protected]>
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
#include "vec/common/schema_util.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'vec/common/schema_util.h' file not found [clang-diagnostic-error]
#include "vec/common/schema_util.h"
^
run buildall |
TeamCity be ut coverage result: |
Problem Summary:
InvertedIndexColumnWriter::check_support_inverted_index
, It is not appropriate to determine support for other indexes by checking the inverted index.TableSchema::update_index()
pick from master #43375