[enchement](orc) improve the read amplification problem caused by orc tiny stripe optimization. #50675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
hubgeter
force-pushed
the
orc_tiny_stripe_enc
branch
2 times, most recently
from
2801c8d to
3befcf5
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33873 ms |
TPC-DS: Total hot run time: 193233 ms |
ClickBench: Total hot run time: 29.83 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
reviewed
May 24, 2025
| range_finder); | ||
| //The first stripe in the read file is selected to calculate an approximate | ||
| // read amplification factor using the tiny stripe optimization. | ||
| std::vector<bool> selectedColumns; |
There was a problem hiding this comment.
Suggested change
| std::vector<bool> selectedColumns; | |
| std::vector<bool> selected_columns; |
hubgeter
force-pushed
the
orc_tiny_stripe_enc
branch
from
3befcf5 to
c3d4c9b
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33616 ms |
TPC-DS: Total hot run time: 192540 ms |
ClickBench: Total hot run time: 29.62 s |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33939 ms |
TPC-DS: Total hot run time: 192989 ms |
ClickBench: Total hot run time: 29.71 s |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33607 ms |
TPC-DS: Total hot run time: 192368 ms |
ClickBench: Total hot run time: 29.7 s |
… tiny stripe optimization.
hubgeter
force-pushed
the
orc_tiny_stripe_enc
branch
from
4516147 to
41221b8
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33799 ms |
TPC-DS: Total hot run time: 194098 ms |
ClickBench: Total hot run time: 29.86 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #42004
orc submodule pr: apache/doris-thirdparty#313
Problem Summary:
In the previous PR #42004 , the optimization of orc tiny stripe was introduced. However, if there are many columns in the orc file and only a few of them are used in a query, the tiny stripe optimization will cause serious read amplification.
This PR introduces the
orc_tiny_stripe_amplification_factorsession variable to adjust the usage scenario of orc tiny stripe optimization. When the actual number of bytes to be read accounts for a larger proportion of the entire stripe than this parameter, read optimization is used. The default value of this parameter is 0.4, and the minimum value is 0.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)