Skip to content

[fix](arrow) Fix convert_to_arrow_type return error #51420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Jun 3, 2025

What problem does this PR solve?

static_cast<void> -> RETURN_IF_ERROR

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Jun 3, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33976 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95b8e573132395623f2639b49c8eeb6edade5669, data reload: false

------ Round 1 ----------------------------------
q1	26281	5198	5039	5039
q2	1941	298	187	187
q3	10326	1248	689	689
q4	10269	997	538	538
q5	8888	2410	2414	2410
q6	271	164	137	137
q7	939	753	620	620
q8	9327	1376	1149	1149
q9	6853	5132	5151	5132
q10	6854	2333	1901	1901
q11	484	294	276	276
q12	337	357	213	213
q13	17775	3669	3059	3059
q14	229	239	214	214
q15	563	498	488	488
q16	435	432	374	374
q17	605	875	359	359
q18	7597	7288	7063	7063
q19	1578	988	580	580
q20	332	334	235	235
q21	3668	3170	2326	2326
q22	1044	1005	987	987
Total cold run time: 116596 ms
Total hot run time: 33976 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5178	5086	5084	5084
q2	239	317	217	217
q3	2186	2650	2308	2308
q4	1370	1767	1336	1336
q5	4281	4137	4147	4137
q6	204	166	128	128
q7	1893	1797	1647	1647
q8	2506	2497	2426	2426
q9	6818	6754	6786	6754
q10	2892	3083	2666	2666
q11	570	496	488	488
q12	634	725	559	559
q13	3357	3655	3097	3097
q14	266	282	268	268
q15	519	479	476	476
q16	429	489	427	427
q17	1132	1508	1319	1319
q18	7350	7214	7188	7188
q19	782	818	927	818
q20	1904	1994	1819	1819
q21	4783	4369	4220	4220
q22	1062	1027	985	985
Total cold run time: 50355 ms
Total hot run time: 48367 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185804 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95b8e573132395623f2639b49c8eeb6edade5669, data reload: false

query1	1007	480	497	480
query2	6578	1836	1835	1835
query3	6759	229	228	228
query4	26535	23624	23123	23123
query5	5032	634	448	448
query6	296	218	203	203
query7	4629	490	304	304
query8	266	221	210	210
query9	8643	2619	2655	2619
query10	487	354	256	256
query11	15826	15061	15093	15061
query12	167	105	105	105
query13	1660	534	436	436
query14	9827	6072	6104	6072
query15	204	192	171	171
query16	7673	625	458	458
query17	1173	752	573	573
query18	2020	406	311	311
query19	195	192	171	171
query20	129	123	118	118
query21	213	125	109	109
query22	4125	4324	4044	4044
query23	34051	33205	33077	33077
query24	8390	2337	2373	2337
query25	534	444	401	401
query26	1236	265	150	150
query27	2722	507	363	363
query28	4289	2144	2126	2126
query29	726	559	420	420
query30	280	211	189	189
query31	916	831	750	750
query32	72	64	65	64
query33	555	371	325	325
query34	790	848	523	523
query35	789	804	727	727
query36	929	969	896	896
query37	109	104	74	74
query38	4121	4176	3997	3997
query39	1546	1412	1401	1401
query40	212	121	104	104
query41	61	63	56	56
query42	123	120	114	114
query43	508	480	461	461
query44	1282	815	806	806
query45	199	175	174	174
query46	839	1034	616	616
query47	1795	1830	1758	1758
query48	375	424	305	305
query49	737	483	385	385
query50	646	674	403	403
query51	4086	4168	4105	4105
query52	115	117	110	110
query53	226	254	197	197
query54	581	570	518	518
query55	83	82	88	82
query56	324	307	292	292
query57	1127	1150	1084	1084
query58	263	252	251	251
query59	2632	2611	2572	2572
query60	328	311	313	311
query61	129	156	126	126
query62	772	761	694	694
query63	224	199	184	184
query64	4274	1015	678	678
query65	4271	4147	4144	4144
query66	1076	408	308	308
query67	16022	15674	15521	15521
query68	8031	872	520	520
query69	479	300	271	271
query70	1173	1117	1112	1112
query71	445	324	303	303
query72	5502	4744	4631	4631
query73	631	564	345	345
query74	9237	8850	9057	8850
query75	3407	3212	2652	2652
query76	3353	1185	752	752
query77	613	385	292	292
query78	9979	10084	9375	9375
query79	1803	816	572	572
query80	577	513	473	473
query81	490	254	224	224
query82	193	126	100	100
query83	256	253	233	233
query84	249	106	95	95
query85	800	358	316	316
query86	381	308	293	293
query87	4444	4516	4380	4380
query88	3028	2254	2250	2250
query89	375	312	286	286
query90	1977	210	203	203
query91	140	139	113	113
query92	77	58	61	58
query93	1879	956	577	577
query94	678	415	296	296
query95	384	292	294	292
query96	493	555	280	280
query97	2720	2730	2646	2646
query98	235	269	219	219
query99	1344	1420	1281	1281
Total cold run time: 274182 ms
Total hot run time: 185804 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.72 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95b8e573132395623f2639b49c8eeb6edade5669, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.11
query3	0.26	0.20	0.19
query4	1.59	0.19	0.19
query5	0.42	0.43	0.41
query6	1.16	0.66	0.67
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.58	0.53	0.53
query10	0.57	0.56	0.57
query11	0.16	0.11	0.10
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	0.79	0.81	0.82
query15	0.87	0.85	0.86
query16	0.38	0.40	0.38
query17	1.02	1.08	1.02
query18	0.22	0.21	0.21
query19	1.91	1.83	1.80
query20	0.02	0.01	0.01
query21	15.40	0.88	0.53
query22	0.76	1.16	0.64
query23	15.02	1.38	0.57
query24	7.23	1.25	0.54
query25	0.50	0.19	0.15
query26	0.68	0.16	0.13
query27	0.05	0.05	0.05
query28	9.60	0.93	0.45
query29	12.56	3.98	3.32
query30	0.26	0.09	0.06
query31	2.82	0.60	0.38
query32	3.23	0.56	0.47
query33	3.11	3.03	3.12
query34	15.81	5.15	4.47
query35	4.50	4.51	4.52
query36	0.66	0.50	0.49
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.15	0.13
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.62 s
Total hot run time: 28.72 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.06% (15023/26800)
Line Coverage 44.92% (134115/298548)
Region Coverage 44.04% (67481/153217)
Branch Coverage 38.60% (34568/89552)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.54% (20985/26383)
Line Coverage 72.60% (216731/298516)
Region Coverage 70.80% (127552/180151)
Branch Coverage 64.54% (66076/102380)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

PR approved by anyone and no changes requested.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit 607bdef into apache:master Jun 4, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants