-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[config](load) improve in-memory aggregation triggering for AGG KEY tables #52305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 33930 ms
|
TPC-DS: Total hot run time: 186311 ms
|
ClickBench: Total hot run time: 29.13 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
What problem does this PR solve?
This commit makes two related changes to enable more efficient and timely
in-memory aggregation during data loading:
Reduce the default value of
write_buffer_size_for_agg
from 400MB to 100MB.The previous default exceeded the
write_buffer_size
(200MB), causingneed_agg()
to never trigger beforeneed_flush()
, effectively skippingthe intended aggregation step.
Refine the
need_agg()
logic to be based on memory growth since the lastaggregation, rather than total memory usage. This is tracked using a new
_last_agg_pos
field, which is updated after each aggregation. This preventsrepeated aggregation when memory usage remains stagnant and allows for
more adaptive and efficient memory management.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)