Skip to content

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 31, 2025

LogicalPostProject is used to cast sink's output slot's datatype according to dest table's schema. Most importantly, make the nullable info is same as dest table

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 189636 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3763894355568cbd83e6e6a2882bf169e4b6c3d6, data reload: false

query1	1043	407	410	407
query2	6560	1702	1721	1702
query3	6762	221	231	221
query4	26713	23406	23193	23193
query5	5794	662	469	469
query6	335	242	215	215
query7	4665	496	304	304
query8	323	264	255	255
query9	8743	2592	2607	2592
query10	556	347	284	284
query11	15283	15236	14894	14894
query12	190	122	116	116
query13	1702	573	453	453
query14	12479	9223	9199	9199
query15	279	200	179	179
query16	7843	712	544	544
query17	1628	807	666	666
query18	2085	491	370	370
query19	301	237	196	196
query20	149	138	140	138
query21	248	151	131	131
query22	4761	4811	4546	4546
query23	35175	33765	33739	33739
query24	8734	2478	2521	2478
query25	605	546	471	471
query26	1832	296	174	174
query27	3073	525	366	366
query28	4383	2254	2185	2185
query29	860	687	527	527
query30	310	232	211	211
query31	964	859	772	772
query32	83	78	72	72
query33	571	396	370	370
query34	818	902	530	530
query35	859	884	808	808
query36	997	1049	928	928
query37	134	117	93	93
query38	3694	3718	3581	3581
query39	1485	1406	1580	1406
query40	218	128	117	117
query41	59	58	60	58
query42	125	114	110	110
query43	467	499	472	472
query44	1217	741	741	741
query45	181	181	172	172
query46	890	999	640	640
query47	1750	1865	1724	1724
query48	384	449	327	327
query49	776	496	425	425
query50	646	689	407	407
query51	3909	3997	3899	3899
query52	114	110	97	97
query53	236	268	205	205
query54	303	294	282	282
query55	88	91	84	84
query56	324	335	299	299
query57	1190	1183	1119	1119
query58	295	284	277	277
query59	2775	2710	2611	2611
query60	351	342	342	342
query61	162	157	152	152
query62	775	724	665	665
query63	232	191	190	190
query64	4450	1161	836	836
query65	4059	3918	3986	3918
query66	1028	441	334	334
query67	15542	15266	14941	14941
query68	7835	940	596	596
query69	502	330	285	285
query70	1415	1267	1231	1231
query71	510	347	335	335
query72	5969	4974	4841	4841
query73	556	562	367	367
query74	9193	9186	8714	8714
query75	4008	3369	2824	2824
query76	3321	1186	732	732
query77	793	407	306	306
query78	9570	9780	8951	8951
query79	1884	850	606	606
query80	691	563	495	495
query81	504	268	238	238
query82	472	162	137	137
query83	274	267	251	251
query84	250	112	96	96
query85	869	492	431	431
query86	342	321	305	305
query87	3760	3889	3660	3660
query88	3501	2298	2292	2292
query89	384	330	296	296
query90	2031	229	227	227
query91	168	172	145	145
query92	84	74	65	65
query93	1128	1027	658	658
query94	697	462	346	346
query95	417	320	307	307
query96	513	585	293	293
query97	2934	2994	2872	2872
query98	243	214	221	214
query99	1659	1422	1291	1291
Total cold run time: 282042 ms
Total hot run time: 189636 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.99 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3763894355568cbd83e6e6a2882bf169e4b6c3d6, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.06	0.05
query3	0.24	0.08	0.08
query4	1.60	0.11	0.11
query5	0.27	0.26	0.27
query6	1.21	0.65	0.63
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.60	0.53	0.52
query10	0.58	0.59	0.57
query11	0.17	0.11	0.12
query12	0.16	0.12	0.12
query13	0.62	0.61	0.62
query14	1.01	1.02	1.01
query15	0.86	0.85	0.85
query16	0.41	0.39	0.41
query17	1.10	1.04	1.03
query18	0.21	0.22	0.20
query19	1.93	1.78	1.84
query20	0.02	0.01	0.02
query21	15.44	0.19	0.14
query22	5.01	0.07	0.05
query23	15.66	0.26	0.10
query24	2.72	0.59	0.85
query25	0.07	0.07	0.06
query26	0.14	0.13	0.13
query27	0.06	0.06	0.06
query28	4.93	1.17	0.94
query29	12.57	4.01	3.30
query30	0.27	0.14	0.11
query31	2.82	0.62	0.38
query32	3.23	0.56	0.48
query33	3.07	3.10	3.11
query34	15.92	5.18	4.61
query35	4.61	4.63	4.63
query36	0.68	0.50	0.50
query37	0.11	0.07	0.06
query38	0.06	0.05	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.15
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.98 s
Total hot run time: 27.99 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.98% (1/102) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 53.92% (55/102) 🎉
Increment coverage report
Complete coverage report

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 27.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a13dd19b8f1762fd7524be8cc29e32693022528, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.04
query3	0.24	0.08	0.08
query4	1.61	0.12	0.12
query5	0.27	0.25	0.26
query6	1.17	0.64	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.61	0.53	0.51
query10	0.58	0.59	0.57
query11	0.17	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.61
query14	1.01	1.00	1.00
query15	0.87	0.84	0.85
query16	0.38	0.38	0.39
query17	1.03	1.02	1.02
query18	0.21	0.20	0.19
query19	1.86	1.76	1.79
query20	0.01	0.01	0.01
query21	15.51	0.18	0.13
query22	5.04	0.08	0.05
query23	15.65	0.27	0.10
query24	2.59	0.53	0.49
query25	0.08	0.06	0.05
query26	0.14	0.12	0.14
query27	0.06	0.06	0.05
query28	4.69	1.15	0.94
query29	12.57	3.90	3.31
query30	0.28	0.14	0.14
query31	2.82	0.59	0.38
query32	3.24	0.55	0.48
query33	3.01	3.04	3.02
query34	15.87	5.23	4.57
query35	4.66	4.59	4.58
query36	0.68	0.51	0.50
query37	0.10	0.07	0.08
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.46 s
Total hot run time: 27.63 s

@starocean999 starocean999 marked this pull request as ready for review November 3, 2025 07:01
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 194cbe3 into apache:master Nov 4, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants