-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix](cloud)Fix read from peer use thread pool not asyncio #57587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
run buildall |
aa47587 to
9b025b9
Compare
|
run buildall |
ClickBench: Total hot run time: 27.97 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
| if (type == PFetchPeerDataRequest_Type_PEER_FILE_RANGE) { | ||
| status = handle_peer_file_range_request(path, response); | ||
| } else if (type == PFetchPeerDataRequest_Type_PEER_FILE_CACHE_BLOCK) { | ||
| status = handle_peer_file_cache_block_request(request, response); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle_peer_file_cache_block_request
and
handle_peer_file_range_request
can be a function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process type in that function
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Related PR:
https://github.com/apache/doris/pull/56384, modify the
enable_cache_read_from_peerconfiguration from false to true.Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)