Skip to content

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Oct 31, 2025

What problem does this PR solve?

Related PR:
https://github.com/apache/doris/pull/56384, modify the enable_cache_read_from_peer configuration from false to true.
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@deardeng
Copy link
Contributor Author

run buildall

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 27.97 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9b025b9f7d119237d7deccb109ac5fbd2bc2db82, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.09
query4	1.61	0.12	0.12
query5	0.28	0.26	0.25
query6	1.18	0.65	0.66
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.60	0.52	0.52
query10	0.59	0.59	0.58
query11	0.17	0.12	0.12
query12	0.17	0.13	0.12
query13	0.62	0.60	0.61
query14	1.02	1.01	1.01
query15	0.86	0.84	0.85
query16	0.39	0.40	0.40
query17	1.09	1.05	1.04
query18	0.22	0.23	0.21
query19	1.95	1.83	1.83
query20	0.02	0.01	0.01
query21	15.44	0.18	0.13
query22	5.15	0.07	0.05
query23	15.67	0.27	0.10
query24	3.05	0.69	0.91
query25	0.07	0.06	0.05
query26	0.15	0.14	0.13
query27	0.06	0.05	0.06
query28	5.10	1.16	0.94
query29	12.65	4.06	3.28
query30	0.28	0.13	0.12
query31	2.82	0.62	0.39
query32	3.22	0.56	0.48
query33	3.18	3.04	3.09
query34	15.78	5.17	4.53
query35	4.62	4.58	4.58
query36	0.68	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.71 s
Total hot run time: 27.97 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.70% (18047/34247)
Line Coverage 37.95% (163861/431752)
Region Coverage 32.30% (124956/386883)
Branch Coverage 33.68% (54615/162140)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 6.25% (7/112) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.40% (24033/33660)
Line Coverage 57.82% (250054/432491)
Region Coverage 52.88% (207519/392469)
Branch Coverage 54.62% (89159/163247)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

if (type == PFetchPeerDataRequest_Type_PEER_FILE_RANGE) {
status = handle_peer_file_range_request(path, response);
} else if (type == PFetchPeerDataRequest_Type_PEER_FILE_CACHE_BLOCK) {
status = handle_peer_file_cache_block_request(request, response);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle_peer_file_cache_block_request
and
handle_peer_file_range_request
can be a function

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process type in that function

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

PR approved by anyone and no changes requested.

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants