Skip to content

Conversation

@morrySnow
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.63% (1673/2075)
Line Coverage 67.01% (29519/44052)
Region Coverage 67.47% (14657/21725)
Branch Coverage 57.76% (7795/13496)

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 16.67% (1/6) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.69% (18045/34247)
Line Coverage 37.95% (163843/431751)
Region Coverage 32.27% (124835/386878)
Branch Coverage 33.69% (54616/162137)

@doris-robot
Copy link

TPC-DS: Total hot run time: 189610 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f131bfeac2fba80e02bbda7a0a5c58bc88035734, data reload: false

query1	1047	407	398	398
query2	6612	1747	1724	1724
query3	6769	223	216	216
query4	26314	23846	23288	23288
query5	4900	624	482	482
query6	353	251	245	245
query7	4655	501	303	303
query8	310	268	248	248
query9	8751	2579	2578	2578
query10	550	342	285	285
query11	15379	15102	14893	14893
query12	195	120	115	115
query13	1689	557	455	455
query14	11210	9128	9145	9128
query15	209	196	190	190
query16	7671	706	476	476
query17	1461	778	656	656
query18	2061	456	379	379
query19	238	230	212	212
query20	145	130	133	130
query21	226	142	118	118
query22	4525	4609	4497	4497
query23	34873	33757	33840	33757
query24	10297	2554	2480	2480
query25	675	547	510	510
query26	1444	276	164	164
query27	2727	532	376	376
query28	4878	2239	2244	2239
query29	817	660	551	551
query30	345	235	209	209
query31	1074	859	764	764
query32	82	66	77	66
query33	613	382	391	382
query34	1638	872	517	517
query35	828	881	785	785
query36	955	1047	917	917
query37	131	108	85	85
query38	3682	3593	3481	3481
query39	1492	1411	1411	1411
query40	219	125	119	119
query41	60	56	55	55
query42	116	108	105	105
query43	486	494	469	469
query44	1203	752	733	733
query45	177	173	166	166
query46	874	992	633	633
query47	1761	1784	1704	1704
query48	380	414	323	323
query49	778	476	420	420
query50	619	683	400	400
query51	3879	3965	3907	3907
query52	110	109	106	106
query53	232	263	195	195
query54	320	294	284	284
query55	89	81	83	81
query56	307	314	312	312
query57	1174	1176	1117	1117
query58	283	274	275	274
query59	2536	2665	2554	2554
query60	338	340	330	330
query61	165	163	162	162
query62	777	731	706	706
query63	226	191	193	191
query64	4498	1161	907	907
query65	4075	3962	3918	3918
query66	1096	434	324	324
query67	15722	15100	14945	14945
query68	8937	878	593	593
query69	493	326	291	291
query70	1325	1294	1317	1294
query71	474	329	322	322
query72	6003	4970	4953	4953
query73	703	571	357	357
query74	8830	8830	8913	8830
query75	3935	3399	2773	2773
query76	3742	1176	731	731
query77	817	420	310	310
query78	9601	9680	8897	8897
query79	2306	833	613	613
query80	660	551	498	498
query81	483	261	233	233
query82	492	158	136	136
query83	302	259	252	252
query84	301	117	90	90
query85	972	477	434	434
query86	342	309	285	285
query87	3740	3775	3653	3653
query88	2906	2257	2241	2241
query89	390	323	298	298
query90	2023	221	219	219
query91	165	165	140	140
query92	80	67	61	61
query93	1124	979	643	643
query94	696	459	324	324
query95	409	315	311	311
query96	490	597	282	282
query97	2937	2963	2873	2873
query98	238	216	205	205
query99	1461	1424	1318	1318
Total cold run time: 281698 ms
Total hot run time: 189610 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.89 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f131bfeac2fba80e02bbda7a0a5c58bc88035734, data reload: false

query1	0.06	0.04	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.63	0.12	0.11
query5	0.28	0.26	0.25
query6	1.20	0.65	0.66
query7	0.03	0.03	0.03
query8	0.06	0.05	0.04
query9	0.62	0.53	0.53
query10	0.58	0.58	0.58
query11	0.17	0.12	0.12
query12	0.15	0.12	0.12
query13	0.62	0.62	0.60
query14	1.02	1.01	1.01
query15	0.87	0.83	0.84
query16	0.38	0.40	0.40
query17	1.02	1.04	1.02
query18	0.22	0.20	0.21
query19	1.94	1.88	1.84
query20	0.01	0.01	0.01
query21	15.43	0.17	0.13
query22	5.19	0.06	0.05
query23	15.67	0.27	0.10
query24	2.22	0.89	0.55
query25	0.07	0.06	0.07
query26	0.14	0.15	0.14
query27	0.07	0.06	0.05
query28	4.33	1.16	0.95
query29	12.58	3.92	3.30
query30	0.28	0.13	0.12
query31	2.84	0.59	0.38
query32	3.23	0.55	0.47
query33	3.08	3.12	3.05
query34	15.92	5.20	4.61
query35	4.62	4.58	4.58
query36	0.68	0.51	0.49
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.08 s
Total hot run time: 27.89 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.32% (19291/33656)
Line Coverage 42.66% (184497/432440)
Region Coverage 37.07% (145489/392432)
Branch Coverage 38.13% (62246/163238)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 83.33% (5/6) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.30% (19284/33656)
Line Coverage 42.62% (184312/432440)
Region Coverage 36.98% (145102/392432)
Branch Coverage 38.08% (62166/163238)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 83.33% (5/6) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow force-pushed the remove_function_set branch from f131bfe to e346ac9 Compare November 3, 2025 09:33
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.71% (1674/2074)
Line Coverage 67.06% (29555/44073)
Region Coverage 67.62% (14705/21748)
Branch Coverage 57.84% (7819/13518)

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.70% (18048/34249)
Line Coverage 37.99% (164057/431857)
Region Coverage 32.31% (125023/386894)
Branch Coverage 33.74% (54717/162186)

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 16.67% (1/6) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.07% (19213/33668)
Line Coverage 42.41% (183479/432602)
Region Coverage 36.75% (144241/392490)
Branch Coverage 37.89% (61875/163295)

@morrySnow morrySnow force-pushed the remove_function_set branch from e346ac9 to d27c70c Compare November 4, 2025 10:08
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.71% (1674/2074)
Line Coverage 67.03% (29546/44080)
Region Coverage 67.59% (14703/21752)
Branch Coverage 57.85% (7821/13520)

@doris-robot
Copy link

TPC-DS: Total hot run time: 188714 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d27c70c4a1fe84cfe7429bc227935164e3b969a9, data reload: false

query1	1074	410	433	410
query2	6548	1690	1684	1684
query3	6758	221	224	221
query4	26311	23602	22969	22969
query5	5258	671	465	465
query6	346	234	222	222
query7	4656	491	299	299
query8	313	251	244	244
query9	8726	2582	2595	2582
query10	534	360	284	284
query11	15346	15190	14794	14794
query12	194	122	119	119
query13	1688	565	429	429
query14	11604	9196	9372	9196
query15	216	190	174	174
query16	7664	677	516	516
query17	1591	782	622	622
query18	2073	487	370	370
query19	266	234	197	197
query20	144	148	153	148
query21	222	136	133	133
query22	4653	4882	4488	4488
query23	34878	33587	33769	33587
query24	9154	2507	2553	2507
query25	594	521	465	465
query26	1281	278	169	169
query27	2733	521	373	373
query28	4391	2219	2226	2219
query29	794	634	507	507
query30	317	231	202	202
query31	929	833	760	760
query32	80	77	75	75
query33	590	409	355	355
query34	825	921	547	547
query35	839	897	801	801
query36	984	1077	936	936
query37	129	112	88	88
query38	3677	3661	3576	3576
query39	1533	1487	1444	1444
query40	214	125	117	117
query41	57	57	56	56
query42	125	109	111	109
query43	494	504	472	472
query44	1226	741	728	728
query45	188	177	175	175
query46	885	985	632	632
query47	1761	1792	1765	1765
query48	380	414	327	327
query49	748	498	397	397
query50	632	684	409	409
query51	3924	3918	3829	3829
query52	110	103	96	96
query53	226	271	193	193
query54	299	286	268	268
query55	85	84	83	83
query56	315	321	314	314
query57	1179	1224	1131	1131
query58	284	271	278	271
query59	2520	2697	2534	2534
query60	343	332	325	325
query61	162	194	183	183
query62	813	704	659	659
query63	233	198	195	195
query64	4534	1266	949	949
query65	4027	3961	3962	3961
query66	1101	445	350	350
query67	15538	15344	14866	14866
query68	8369	870	592	592
query69	497	352	303	303
query70	1374	1314	1211	1211
query71	467	338	319	319
query72	6030	4928	4868	4868
query73	640	584	365	365
query74	9191	8764	8642	8642
query75	3307	3360	2807	2807
query76	3299	1147	745	745
query77	521	389	315	315
query78	9637	9672	8874	8874
query79	2713	803	600	600
query80	693	554	496	496
query81	497	251	234	234
query82	497	154	136	136
query83	267	273	243	243
query84	259	109	98	98
query85	908	476	428	428
query86	384	312	292	292
query87	3647	3695	3654	3654
query88	3846	2259	2255	2255
query89	387	325	286	286
query90	2064	216	222	216
query91	179	170	134	134
query92	85	69	66	66
query93	2352	997	631	631
query94	739	434	339	339
query95	406	321	323	321
query96	488	583	280	280
query97	2941	2958	2870	2870
query98	244	214	220	214
query99	1358	1410	1309	1309
Total cold run time: 280602 ms
Total hot run time: 188714 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.01 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d27c70c4a1fe84cfe7429bc227935164e3b969a9, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.04
query3	0.26	0.09	0.09
query4	1.60	0.12	0.12
query5	0.28	0.26	0.26
query6	1.20	0.68	0.66
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.59	0.53	0.53
query10	0.57	0.57	0.58
query11	0.17	0.11	0.12
query12	0.16	0.13	0.12
query13	0.64	0.62	0.60
query14	1.02	1.00	1.02
query15	0.88	0.84	0.87
query16	0.40	0.41	0.40
query17	1.03	1.03	1.07
query18	0.22	0.20	0.21
query19	1.96	1.88	1.85
query20	0.02	0.02	0.02
query21	15.42	0.19	0.13
query22	5.14	0.07	0.05
query23	15.68	0.28	0.11
query24	2.65	0.70	0.52
query25	0.07	0.06	0.06
query26	0.15	0.13	0.12
query27	0.06	0.05	0.06
query28	4.21	1.21	0.93
query29	12.59	3.97	3.36
query30	0.29	0.15	0.12
query31	2.82	0.64	0.40
query32	3.23	0.59	0.48
query33	3.04	3.06	3.16
query34	15.92	5.31	4.59
query35	4.60	4.63	4.62
query36	0.70	0.51	0.50
query37	0.10	0.06	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.19	0.14	0.14
query41	0.08	0.03	0.04
query42	0.04	0.04	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.36 s
Total hot run time: 28.01 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.73% (18083/34294)
Line Coverage 38.05% (164477/432294)
Region Coverage 32.35% (125283/387299)
Branch Coverage 33.80% (54896/162402)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.00% (24609/33713)
Line Coverage 60.04% (260004/433039)
Region Coverage 55.15% (216698/392895)
Branch Coverage 57.17% (93485/163511)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants