Skip to content

branch-4.0: [function](agg) support agg function of group_array_union #57166 #57596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

branch-4.0: [function](agg) support agg function of group_array_union #57166 #57596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 42 additions & 11 deletions be/src/exprs/hybrid_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ class HybridSetBase : public FilterBase {
// use in vectorize execute engine
virtual void insert(void* data, size_t) = 0;

virtual void insert_range_from(const vectorized::ColumnPtr& column, size_t start,
size_t end) = 0;

virtual void insert_fixed_len(const vectorized::ColumnPtr& column, size_t start) = 0;

virtual void insert(HybridSetBase* set) {
Expand Down Expand Up @@ -291,8 +294,16 @@ class HybridSet : public HybridSetBase {
void insert(void* data, size_t /*unused*/) override { insert(data); }

void insert_fixed_len(const vectorized::ColumnPtr& column, size_t start) override {
const auto size = column->size();
insert_range_from(column, start, column->size());
}

void insert_range_from(const vectorized::ColumnPtr& column, size_t start, size_t end) override {
if (end > column->size()) {
throw doris::Exception(doris::ErrorCode::INTERNAL_ERROR,
"Parameters start = {}, end = {}, are out of bound in "
"HybridSet::insert_range_from method (data.size() = {}).",
start, end, column->size());
}
if (column->is_nullable()) {
const auto* nullable = assert_cast<const vectorized::ColumnNullable*>(column.get());
const auto& col = nullable->get_nested_column();
Expand All @@ -301,7 +312,7 @@ class HybridSet : public HybridSetBase {
.get_data();

const ElementType* data = (ElementType*)col.get_raw_data().data;
for (size_t i = start; i < size; i++) {
for (size_t i = start; i < end; i++) {
if (!nullmap[i]) {
_set.insert(*(data + i));
} else {
Expand All @@ -310,7 +321,7 @@ class HybridSet : public HybridSetBase {
}
} else {
const ElementType* data = (ElementType*)column->get_raw_data().data;
for (size_t i = start; i < size; i++) {
for (size_t i = start; i < end; i++) {
_set.insert(*(data + i));
}
}
Expand Down Expand Up @@ -448,6 +459,16 @@ class StringSet : public HybridSetBase {
}

void insert_fixed_len(const vectorized::ColumnPtr& column, size_t start) override {
insert_range_from(column, start, column->size());
}

void insert_range_from(const vectorized::ColumnPtr& column, size_t start, size_t end) override {
if (end > column->size()) {
throw doris::Exception(doris::ErrorCode::INTERNAL_ERROR,
"Parameters start = {}, end = {}, are out of bound in "
"StringSet::insert_range_from method (data.size() = {}).",
start, end, column->size());
}
if (column->is_nullable()) {
const auto* nullable = assert_cast<const vectorized::ColumnNullable*>(column.get());
const auto& nullmap =
Expand All @@ -456,19 +477,19 @@ class StringSet : public HybridSetBase {
if (nullable->get_nested_column().is_column_string64()) {
_insert_fixed_len_string(assert_cast<const vectorized::ColumnString64&>(
nullable->get_nested_column()),
nullmap.data(), start, nullmap.size());
nullmap.data(), start, end);
} else {
_insert_fixed_len_string(
assert_cast<const vectorized::ColumnString&>(nullable->get_nested_column()),
nullmap.data(), start, nullmap.size());
nullmap.data(), start, end);
}
} else {
if (column->is_column_string64()) {
_insert_fixed_len_string(assert_cast<const vectorized::ColumnString64&>(*column),
nullptr, start, column->size());
nullptr, start, end);
} else {
_insert_fixed_len_string(assert_cast<const vectorized::ColumnString&>(*column),
nullptr, start, column->size());
nullptr, start, end);
}
}
}
Expand Down Expand Up @@ -618,6 +639,16 @@ class StringValueSet : public HybridSetBase {
}

void insert_fixed_len(const vectorized::ColumnPtr& column, size_t start) override {
insert_range_from(column, start, column->size());
}

void insert_range_from(const vectorized::ColumnPtr& column, size_t start, size_t end) override {
if (end > column->size()) {
throw doris::Exception(doris::ErrorCode::INTERNAL_ERROR,
"Parameters start = {}, end = {}, are out of bound in "
"StringSet::insert_range_from method (data.size() = {}).",
start, end, column->size());
}
if (column->is_nullable()) {
const auto* nullable = assert_cast<const vectorized::ColumnNullable*>(column.get());
const auto& nullmap =
Expand All @@ -626,19 +657,19 @@ class StringValueSet : public HybridSetBase {
if (nullable->get_nested_column().is_column_string64()) {
_insert_fixed_len_string(assert_cast<const vectorized::ColumnString64&>(
nullable->get_nested_column()),
nullmap.data(), start, nullmap.size());
nullmap.data(), start, end);
} else {
_insert_fixed_len_string(
assert_cast<const vectorized::ColumnString&>(nullable->get_nested_column()),
nullmap.data(), start, nullmap.size());
nullmap.data(), start, end);
}
} else {
if (column->is_column_string64()) {
_insert_fixed_len_string(assert_cast<const vectorized::ColumnString64&>(*column),
nullptr, start, column->size());
nullptr, start, end);
} else {
_insert_fixed_len_string(assert_cast<const vectorized::ColumnString&>(*column),
nullptr, start, column->size());
nullptr, start, end);
}
}
}
Expand Down
66 changes: 0 additions & 66 deletions be/src/vec/aggregate_functions/aggregate_function_group_array_intersect.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading