URIExtractionNamespace: Avoid problems due to canonicalization of lookup fields. #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kup fields. Disables canonicalization for simpleJson, where expect field names to be unique anyway. Keeps canonicalization enabled for customJson, but avoids sharing the table with the global ObjectMapper.
drcrallen
reviewed
May 22, 2017
| this.parser = new DelegateParser( | ||
| new JSONParser(jsonMapper, ImmutableList.of(keyFieldName, valueFieldName)), | ||
| new JSONParser(jsonMapper.copy(), ImmutableList.of(keyFieldName, valueFieldName)), |
There was a problem hiding this comment.
There are bugs with jsonmapper copy if I recall. So the behavior of the copy might vary with Jackson version.
There was a problem hiding this comment.
Do you remember what kind of bugs?
If it's things along the lines of "not all configs and modules are copied" then that should be fine -- the jsonMapper shouldn't be finicky to that, since it's just reading generic Map<String, String> and not serializing anything.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the link. This should be fine then, it doesn't matter or not if we have injectable values for these parsers that just want to read Map<String, String>.
|
👍 |
drcrallen
approved these changes
May 25, 2017
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
May 26, 2017
…kup fields. (apache#4307) Disables canonicalization for simpleJson, where expect field names to be unique anyway. Keeps canonicalization enabled for customJson, but avoids sharing the table with the global ObjectMapper.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 14, 2017
…kup fields. (apache#4307) Disables canonicalization for simpleJson, where expect field names to be unique anyway. Keeps canonicalization enabled for customJson, but avoids sharing the table with the global ObjectMapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables canonicalization for simpleJson, where we expect field names to be unique
anyway. Keeps canonicalization enabled for customJson, but avoids sharing the
table with the global ObjectMapper.
This fixed an issue we saw where canonicalization of simpleJson fields caused serious
performance problems (taking >2 minutes to read a 22MB file).