复现只有一台provider 时, MergeableClusterInvoker 的bug #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
AlbumenJ
requested changes
Mar 15, 2021
dubbo-samples-merge/dubbo-samples-merge-provider1/src/main/resources/spring/merge-provider.xml
Outdated
Show resolved
Hide resolved
AlbumenJ
reviewed
Mar 22, 2021
| ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext("spring/dubbo-consumer.xml"); | ||
| context.start(); | ||
|
|
||
| IDubboService dubboService = (IDubboService) context.getBean("dubboService"); |
There was a problem hiding this comment.
Pls convert this case to integration test so it can verify automatically
There was a problem hiding this comment.
yeah, a file which was commited a few minutes ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
复现只有一台provider 时, MergeableClusterInvoker 的bug, for dubbo issues:
to fix something wrong with MergeableClusterInvoker #7359