Triple flowcontrol #10811
Closed
Triple flowcontrol #10811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.2 #10811 +/- ##
============================================
- Coverage 64.68% 64.66% -0.03%
+ Complexity 390 389 -1
============================================
Files 1342 1345 +3
Lines 57276 57811 +535
Branches 8446 8512 +66
============================================
+ Hits 37047 37381 +334
- Misses 16244 16397 +153
- Partials 3985 4033 +48
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
guohao
requested changes
Nov 22, 2022
| Assertions.assertTrue(listener.started); | ||
| stream.request(2); | ||
| byte[] data = new byte[]{0, 0, 0, 0, 1, 1}; | ||
| final ByteBuf buf = Unpooled.wrappedBuffer(data); | ||
| transportListener.onData(buf, false); | ||
| Http2DataFrame fame = new DefaultHttp2DataFrame(buf); |
| @@ -173,12 +173,14 @@ public final void onComplete() { | |||
| } | |||
|
|
|||
| @Override | |||
| public final void onMessage(byte[] message) { | |||
| public final void onMessage(TripleFlowControlFrame data) { | |||
There was a problem hiding this comment.
FlowControlFrame should not be known by Call class
|
|
||
| private Object instance; | ||
|
|
||
| public TripleFlowControlFrame(Http2Connection http2Connection, int windowSizeIncrement, Http2WindowUpdateFrame http2WindowUpdateFrame, byte[] message){ |
There was a problem hiding this comment.
Decouple message bytes , instance and flow control related field maybe better
| /** | ||
| * This design is learning from {@see io.netty.handler.codec.http2.DefaultHttp2RemoteFlowController} which is in Netty. | ||
| */ | ||
| @UnstableApi |
There was a problem hiding this comment.
TLDR, why copy instead just use netty directly?
There was a problem hiding this comment.
because netty directly will consumeBytes to when received data, i use new function consumeTriBytes to instead it. so it can consumeBytes when after dubbo invoke.
| @@ -46,7 +47,7 @@ public AbstractServerCallListener(RpcInvocation invocation, Invoker<?> invoker, | |||
| this.responseObserver = responseObserver; | |||
| } | |||
|
|
|||
| public void invoke() { | |||
| public void invoke(TripleFlowControlFrame tripleFlowControlBean) { | |||
There was a problem hiding this comment.
call may only need a common data class as param, no need to know flow control
| @@ -59,6 +60,12 @@ public void invoke() { | |||
| final long stInMillis = System.currentTimeMillis(); | |||
| try { | |||
| final Result response = invoker.invoke(invocation); | |||
| //unary and serverstream add flowcontrol update windowsize | |||
| if(null != tripleFlowControlBean && null != tripleFlowControlBean.getHttp2Connection() && tripleFlowControlBean.getWindowSizeIncrement() > 0 && null != tripleFlowControlBean.getHttp2WindowUpdateFrame()){ | |||
There was a problem hiding this comment.
This may lead to queueing on IO when inovke is slow
| public BiStreamServerCallListener(RpcInvocation invocation, Invoker<?> invoker, | ||
| ServerCallToObserverAdapter<Object> responseObserver) { | ||
| super(invocation, invoker, responseObserver); | ||
| invocation.setArguments(new Object[]{responseObserver}); | ||
| invoke(); | ||
| invoke(null); |
|
link #11011 |
|
conflic too much，link #11011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Related with #10748
sample:
apache/dubbo-samples#531
Brief changelog
Verifying this change
Checklist