Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

interoperable - framework changes #7

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

marta-jankovics
Copy link

No description provided.

@myrle-krantz
Copy link
Member

Hey Marta,

I can't tell what you've changed at what you haven't Could you please keep the arrangement of the code as is to make code reviews easier. Also, can you please add a comment to explain what your change does?

Thank you,
Myrle

@awasum
Copy link
Contributor

awasum commented Aug 28, 2019

@marta-jankovics , Will you be able to answer @myrle-krantz 's questions?

Is there a wiki page or JIRA ticket or mailing list discussion on this feature? Sounds like it part of a bigger set of functionality.

@marta-jankovics
Copy link
Author

Hi Myrle, Awasum,

Yes this request is part of a bigger project of creating new microservice which allows Fineract to process interoperable requests.
99% of the changes is covered by another pull request of the new microservice but with this request I also had to make some small changes in existing services to provide support for the new service. I did not change any existing functionality, but added new REST endpoints or extended the visibility of existing services.
If you are interested in more details, we also created a handower document which has a Fineract CN section.
@myrle-krantz I tried not to change anything else but what I really had to including the arrangement of the existing code and now I re-checked the major changes of the request but could not find any problem. Could you please refer to the exact code which you found problematic.

Thank you,
Marta

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants