FINERACT-2148: Fix undoChargeOff method for zero interest behaviour

apache · Dec 13, 2024 · cb89cf1 · cb89cf1
1 parent da87272
commit cb89cf1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java b/fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
@@ -1588,8 +1588,11 @@ public List<LoanTransaction> retrieveListOfTransactionsForReprocessing() {
     }
 
     private static Predicate<LoanTransaction> loanTransactionForReprocessingPredicate() {
-        return transaction -> transaction.isNotReversed() && (transaction.isChargeOff() || transaction.isReAge()
-                || transaction.isAccrualActivity() || transaction.isReAmortize() || !transaction.isNonMonetaryTransaction());
+        return transaction -> transaction.isNotReversed()
+                && (transaction.isChargeOff() || transaction.isReAge() || transaction.isAccrualActivity() || transaction.isReAmortize()
+                        || !transaction.isNonMonetaryTransaction())
+                || transaction.isReversed() && transaction.isChargeOff() && LoanChargeOffBehaviour.ZERO_INTEREST
+                        .equals(transaction.getLoan().getLoanProductRelatedDetail().getChargeOffBehaviour());
     }
 
     public List<LoanTransaction> retrieveListOfTransactionsExcludeAccruals() {

diff --git a/...account/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java b/...account/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
@@ -1172,8 +1172,8 @@ private void handleOverpayment(Money overpaymentPortion, LoanTransaction loanTra
 
     private void handleChargeOff(final LoanTransaction loanTransaction, final TransactionCtx transactionCtx) {
         if (transactionCtx instanceof ProgressiveTransactionCtx progressiveTransactionCtx) {
-            if (LoanChargeOffBehaviour.ZERO_INTEREST
-                    .equals(loanTransaction.getLoan().getLoanProductRelatedDetail().getChargeOffBehaviour())) {
+            if (LoanChargeOffBehaviour.ZERO_INTEREST.equals(loanTransaction.getLoan().getLoanProductRelatedDetail().getChargeOffBehaviour())
+                    && !loanTransaction.isReversed()) {
                 handleZeroInterestChargeOff(loanTransaction, progressiveTransactionCtx);
             }
         }

diff --git a/...che/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java b/...che/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
@@ -3348,6 +3348,9 @@ public CommandProcessingResult undoChargeOff(JsonCommand command) {
         saveLoanWithDataIntegrityViolationChecks(loan);
         postJournalEntries(loan, existingTransactionIds, existingReversedTransactionIds);
         businessEventNotifierService.notifyPostBusinessEvent(new LoanUndoChargeOffBusinessEvent(chargedOffTransaction));
+
+        loan.reprocessTransactions();
+
         return new CommandProcessingResultBuilder() //
                 .withOfficeId(loan.getOfficeId()) //
                 .withClientId(loan.getClientId()) //