FINERACT-1981: Update Payable Interest Calculation For LoanSummaryData #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somasorosdpc
force-pushed
the
FINERACT-1981/update-payable-interest-calculation
branch
from
d8e92c3 to
e25698c
Compare
janez89
approved these changes
Nov 21, 2024
somasorosdpc
force-pushed
the
FINERACT-1981/update-payable-interest-calculation
branch
2 times, most recently
from
6ac3d18 to
b4a24a6
Compare
adamsaghy
reviewed
Nov 25, 2024
| import org.junit.jupiter.api.Assertions; | ||
|
|
||
| @Slf4j | ||
| public class LoanPrepayAmountTest extends BaseLoanIntegrationTest { |
There was a problem hiding this comment.
Would you mind to test what are the balances at 1 Feb which is the due date?
Would you mind adding a test case that shows if something was paid, it is showing only the not yet paid portions?
There was a problem hiding this comment.
I've added verification for Jan 31 and Feb 1
adamsaghy
reviewed
Nov 25, 2024
...va/org/apache/fineract/portfolio/loanaccount/service/ProgressiveLoanSummaryDataProvider.java
Outdated
Show resolved
Hide resolved
somasorosdpc
force-pushed
the
FINERACT-1981/update-payable-interest-calculation
branch
from
b4a24a6 to
f75041d
Compare
janez89
approved these changes
Nov 26, 2024
somasorosdpc
force-pushed
the
FINERACT-1981/update-payable-interest-calculation
branch
3 times, most recently
from
61b3a62 to
5d2fc47
Compare
somasorosdpc
force-pushed
the
FINERACT-1981/update-payable-interest-calculation
branch
from
5d2fc47 to
f786d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.