Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2174: add tests for validation of interestRecognitionOnDisbursementDate setting application under certain conditions #4422

Conversation

ruzeynalov
Copy link

Description

Added e2e tests for validation of interestRecognitionOnDisbursementDate setting application under certain conditions:

  • Pay on time
  • Early repayment
  • Early repayment on disbursement

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [-] Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [-] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@ruzeynalov ruzeynalov force-pushed the feature/FINERACT-2174-interestRecognitionOnDisbursementDateExpandCoverage branch 2 times, most recently from 321c162 to 27062d5 Compare March 5, 2025 13:35
…rsementDate setting application under certain conditions
@ruzeynalov ruzeynalov force-pushed the feature/FINERACT-2174-interestRecognitionOnDisbursementDateExpandCoverage branch from 27062d5 to ecb177e Compare March 5, 2025 15:58
Copy link
Contributor

@peter-kovacs-dpc peter-kovacs-dpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit bd66037 into apache:develop Mar 5, 2025
10 checks passed
@adamsaghy adamsaghy deleted the feature/FINERACT-2174-interestRecognitionOnDisbursementDateExpandCoverage branch March 5, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants