FINERACT-2250: New command processing - Maker Checker (org.apache.fineract.commands) #5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidakovic
reviewed
Oct 6, 2025
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class DeleteMakerCheckerCommandHandler implements CommandHandler<DeleteMakerCheckerRequest, DeleteMakerCheckerResponse> { |
vidakovic
reviewed
Oct 6, 2025
| public class ApproveRejectMakerCheckerCommandHandler | ||
| implements CommandHandler<ApproveRejectMakerCheckerRequest, ApproveRejectMakerCheckerResponse> { | ||
|
|
||
| private final PortfolioCommandSourceWritePlatformService writePlatformService; |
vidakovic
reviewed
Oct 6, 2025
| + "makercheckers?officeId=1\n" + "\n" + "makercheckers?officeId=1&includeJson=true") | ||
| public List<AuditData> retrieveCommands(@Context final UriInfo uriInfo, @BeanParam MakerCheckerRequest makerCheckerRequest) { | ||
| final SQLBuilder extraCriteria = getExtraCriteria(makerCheckerRequest); | ||
|
|
There was a problem hiding this comment.
Not sure if this should be secured!?? Usually there is a validation happening here...
vidakovic
reviewed
Oct 6, 2025
| @Path("/v1/makercheckers") | ||
| @Component | ||
| @Tag(name = "Maker Checker (or 4-eye) functionality") | ||
| @Consumes({ MediaType.APPLICATION_JSON }) |
There was a problem hiding this comment.
Let's leave per function annotations... scope too broad
vidakovic
reviewed
Oct 6, 2025
| @Getter | ||
| @Setter | ||
| @SuperBuilder | ||
| public class DeleteMakerCheckerResponse extends MakerCheckerResponseDTO implements Serializable { |
There was a problem hiding this comment.
Request and responses should be as simple as possible... extending a parent is not. Embrace duplication (for request and response attributes), don't tie things to a common ancestor; this makes things very rigid... and over time use cases (and attributes) will diverge.
There was a problem hiding this comment.
I will re-write this PR according to the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
New Command processing infrastructure added for MakerChecker
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.