Skip to content

Conversation

GreatEugenius
Copy link
Collaborator

Linked issue: #209

Purpose of change

Update the monitoring introduction for Flink agents.

Tests

API

Documentation

Yes

@GreatEugenius GreatEugenius requested a review from Sxnan October 6, 2025 10:53
@GreatEugenius
Copy link
Collaborator Author

@Sxnan please help take a look this PR, thanks.

Copy link
Contributor

@Sxnan Sxnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please see my comments below.

@GreatEugenius GreatEugenius requested a review from Sxnan October 7, 2025 01:33
Copy link
Contributor

@Sxnan Sxnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! LGTM.

@xintongsong Could you have a look at this PR?

└── events-{jobId}-{taskName}-{subtaskId}.log
```

By default, all File-based Event Logs are stored in the `flink-agents` subdirectory under the system temporary directory (`java.io.tmpdir`). In future versions, we plan to add a configurable parameter to allow users to customize the base log directory, providing greater control over log storage paths and lifecycle management.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the tmpdir? Shouldn't it be the log dir?

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xintongsong xintongsong merged commit e17387f into apache:main Oct 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants