[FLINK-36793][cdc-source-connectors] Fix the problem with the block splitter logic of Oracle CDC incremental snapshot, causing the split slice to be too large #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plitter logic of Oracle CDC incremental snapshot, causing the split slice to be too large
leonardBang
reviewed
Jan 8, 2025
| @@ -261,12 +261,16 @@ protected Column getSplitColumn(Table table, @Nullable String chunkKeyColumn) { | |||
| } | |||
|
|
|||
| /** ChunkEnd less than or equal to max. */ | |||
| protected boolean isChunkEndLeMax(Object chunkEnd, Object max, Column splitColumn) { | |||
| protected boolean isChunkEndLeMax( | |||
| JdbcConnection jdbc, Object chunkEnd, Object max, Column splitColumn) | |||
There was a problem hiding this comment.
Here we'd better to annotate @Nullable JdbcConnection jdbc for some dialect they do not need connection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem with the block splitter logic of Oracle CDC incremental snapshot, causing the split slice to be too large.
java api compare rowid result:
sql api compare rowid result:
The comparison results will be different, causing the last chunk size to be too large. The reason is that the logic of Java comparison and SQL comparison of rowids will be different.