[FLINK-33073][Connectors/AWS] Implement end-to-end tests for KinesisS… #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlteoh37
force-pushed
the
end-to-end-test
branch
4 times, most recently
from
3d70220 to
43c35f5
Compare
dannycranmer
requested changes
Sep 15, 2023
...2e-tests/src/test/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkITCase.java
Outdated
Show resolved
Hide resolved
...2e-tests/src/test/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkITCase.java
Outdated
Show resolved
Hide resolved
...2e-tests/src/test/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkITCase.java
Outdated
Show resolved
Hide resolved
...2e-tests/src/test/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkITCase.java
Show resolved
Hide resolved
hlteoh37
force-pushed
the
end-to-end-test
branch
4 times, most recently
from
75f03d9 to
e7e7694
Compare
|
Verified that running AWS end-to-end tests locally all pass |
hlteoh37
force-pushed
the
end-to-end-test
branch
from
e7e7694 to
089c60e
Compare
dannycranmer
requested changes
Sep 27, 2023
...e-tests/src/test/java/org/apache/flink/connector/kinesis/testutils/AWSEndToEndTestUtils.java
Show resolved
Hide resolved
...ts/src/test/java/org/apache/flink/connector/kinesis/testutils/AWSKinesisResourceManager.java
Show resolved
Hide resolved
| LOGGER.info("Successfully created Kinesis Data Stream with ARN {}.", streamARN); | ||
|
|
||
| LOGGER.info("Waiting until Kinesis Data Stream with ARN {} is ACTIVE.", streamARN); | ||
| kinesisWaiter.waitUntilStreamExists( |
There was a problem hiding this comment.
Just checking this waits for stream to be ACTIVE? It is not too clear from the docs
There was a problem hiding this comment.
Yep we can see this from the API itself
| @AfterEach | ||
| void teardown() { | ||
| kinesisResourceManager.close(); | ||
| AWSGeneralUtil.closeResources(httpClient, kinesisClient); |
There was a problem hiding this comment.
Should we run cleanUpStaleKinesisDataStreams(); on @AfterClass as to speed up the tests? And possibly on @BeforeClass incase the tests starts failing...
There was a problem hiding this comment.
Thats a good idea. As discussed offline - moving this to a separate "dummy" test class
hlteoh37
force-pushed
the
end-to-end-test
branch
from
089c60e to
490422b
Compare
dannycranmer
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…treamsSink
Purpose of the change
Implement end-to-end tests for KinesisStreamsSink.
Verifying this change
This change added tests and can be verified as follows:
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))