Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36906] Optimize the logic for determining if a split is finished #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

xiaochen-zhou
Copy link
Contributor

When determining if a split is finished, process only the partitions with data from the current fetch instead of all partitions. This reduces unnecessary partition checks and improves performance and resource utilization.

@xiaochen-zhou
Copy link
Contributor Author

Friendly ping, do you have time to take a look @AHeise 🙏 ?

@AHeise
Copy link
Contributor

AHeise commented Dec 16, 2024

Afaik this doesn't work and was the main reason for #100. If you last message is a transaction marker, then you would never check the stop condition on that partition at the point in time.

I'll trigger the CI which should fail for the test that was specifically added for that scenario.

I'll leave this PR open untli we figured out if it can indeed be improved. Please double check the linked PR and the respective ticket.

@xiaochen-zhou
Copy link
Contributor Author

Afaik this doesn't work and was the main reason for #100. If you last message is a transaction marker, then you would never check the stop condition on that partition at the point in time.

I'll trigger the CI which should fail for the test that was specifically added for that scenario.

I'll leave this PR open untli we figured out if it can indeed be improved. Please double check the linked PR and the respective ticket.

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants