[FLINK-37320] [Observer] FINISHED finite streaming jobs incorrectly being set to RECONCILING #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyfora
reviewed
Feb 19, 2025
| deploymentStatus.getJobStatus().setState(JobStatus.RECONCILING); | ||
|
|
||
| if (!ReconciliationUtils.isJobInTerminalState(deploymentStatus)) { | ||
| deploymentStatus.getJobStatus().setState(JobStatus.RECONCILING); |
There was a problem hiding this comment.
Can you please add a unit test to guard this change against accidental future regressions?
There was a problem hiding this comment.
All done. Happy to make any other changes.
|
rebase on main for docker fix |
…eing set to RECONCILING
luca-p-castelli
force-pushed
the
lc.finished-job-issue
branch
from
72066b7 to
ec78f1a
Compare
gyfora
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes a bug where the observer tries changing the JOB STATUS of a FINISHED finite/bounded streaming job back to RECONCILING if the JM is MISSING.
Brief change log
Wraps AbstractFlinkDeploymentObserver.observeJmDeployment in an if-statement that only executes if the job is NOT in a terminal state.
Verifying this change
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: NoDocumentation