[FLINK-28022][python] Support Google Cloud PubSub connector in Python DataStream API #20627
+516
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dianfu Could you review for me? Thanks a lot! |
dianfu
reviewed
Oct 17, 2022
| @@ -101,4 +101,40 @@ under the License. | |||
| <scope>test</scope> | |||
| </dependency> | |||
| </dependencies> | |||
|
|
|||
| <build> | |||
There was a problem hiding this comment.
It would be great to add a module flink-sql-connector-gcp-pubsub and move the following logic there.
| deserialization_schema._j_serialization_schema) | ||
| return PubSubSink.ProjectNameBuilder(_j_serialization_schema) | ||
|
|
||
| class ProjectNameBuilder(object): |
There was a problem hiding this comment.
Why not call it PubSubSinkBuilder just as the Java API?
| _j_project_name = self._j_project_name_builder.withProjectName(project_name) | ||
| return PubSubSink.TopicNameBuilder(_j_project_name) | ||
|
|
||
| class TopicNameBuilder(object): |
There was a problem hiding this comment.
I prefer to merge it with PubSubSinkBuilder and call it PubSubSinkBuilder
| """ | ||
| JEmulatorCredentialsProvider = get_gateway().jvm. \ | ||
| org.apache.flink.streaming.connectors.gcp.pubsub.emulator.EmulatorCredentialsProvider | ||
| return Credentials(JEmulatorCredentialsProvider.create().getCredentials()) |
There was a problem hiding this comment.
Suggested change
| return Credentials(JEmulatorCredentialsProvider.create().getCredentials()) | |
| return Credentials(JEmulatorCredentials.getInstance())? |
| @@ -73,6 +73,13 @@ def _install(): | |||
| setattr(connectors, 'StreamFormat', file_system.StreamFormat) | |||
| setattr(connectors, 'StreamingFileSink', file_system.StreamingFileSink) | |||
|
|
|||
| # pubsub | |||
| from pyflink.datastream.connectors import pubsub | |||
There was a problem hiding this comment.
This is for backward compatibility. Since pubsub is newly introduced, so this is not necessary and could be removed.
Besides, we may need to add some documentation here: https://github.com/apache/flink/blob/master/flink-python/pyflink/datastream/__init__.py#L209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improve the documentation by adding Python examples.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation