[FLINK-30284][flink-metrics] Adding datacenter url property to datadog #25592
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecating dataCenter for a more configurable dataCenterUrl property
davidradl
reviewed
Dec 10, 2024
| this.configTags = getTagsFromConfig(tags); | ||
|
|
||
| LOGGER.info( | ||
| "Configured DatadogHttpReporter with {tags={}, proxyHost={}, proxyPort={}, dataCenter={}, maxMetricsPerRequest={}", | ||
| "Configured DatadogHttpReporter with {tags={}, proxyHost={}, proxyPort={}, dataCenterUrl={}, maxMetricsPerRequest={}", |
There was a problem hiding this comment.
I was thinking you would keep the original constructor and deprecate it and add a new constructor for the url.
The log here would then come out reflecting the users config.
I see you have refactored the callers to send through the url. deprecating might be cleaner. WDYT ?
The methods should all have @publicEvolving @internal tags as appropriate in all the methods in all the classes
davidradl
reviewed
Dec 10, 2024
| @@ -257,7 +257,8 @@ Parameters: | |||
| - `apikey` - the Datadog API key | |||
| - `proxyHost` - (optional) The proxy host to use when sending to Datadog. | |||
| - `proxyPort` - (optional) The proxy port to use when sending to Datadog, defaults to 8080. | |||
| - `dataCenter` - (optional) The data center (`EU`/`US`) to connect to, defaults to `US`. | |||
| - `dataCenter` - (deprecated/optional) The data center (`EU`/`US`) to connect to, defaults to `US`. *DEPRECATED* will be removed in a future flink version, please use `dataCenterUrl`. | |||
| - `dataCenterUrl`- (optional) The datacenter url to connect to, defaults to `https://app.datadoghq.com`. | |||
There was a problem hiding this comment.
I suggest removing the deprecated option from the example below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change deprecates the
dataCenterconfiguration for DataDog reporter and replaces it withdataCenterUrlthat allows users to configure whole address of the data center to use.Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is already covered by existing tests, such as
DatadogHttpClientTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation