[FLINK-36760][sql-client] Supports to deploy script via sql client #25754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n application mode
|
Reviewed by Chi on 12/12/24 Group to test and/or review outside of the meeting. @tomncooper one you might want to look at. |
hackergin
reviewed
Dec 14, 2024
| @@ -251,6 +254,11 @@ public List<String> completeStatement(String statement, int position) { | |||
| throw new UnsupportedOperationException(); | |||
| } | |||
|
|
|||
| @Override | |||
| public String deployScript(@Nullable String script, @Nullable @Nullable URI path) { | |||
There was a problem hiding this comment.
The @nullable annotation here seems to be duplicated.
| @@ -213,6 +213,8 @@ public AttributedString build() { | |||
|
|
|||
| public static final String MESSAGE_EXECUTE_STATEMENT = "Execute statement succeeded."; | |||
|
|
|||
| public static final String MESSAGE_DEPLOY_SCRIPT = "Deploy script in cluster: "; | |||
There was a problem hiding this comment.
The log message ‘Deploy script in cluster’ could be improved. It would be helpful to explicitly indicate that this is submitting in Application mode and include the corresponding clusterId as xx to enhance readability and informativeness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support to deploy script via SQL Client.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation