Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36889] Mention locking down a Flink cluster in the 'Production Readiness Checklist' #25793

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Samrat002
Copy link
Contributor

What is the purpose of the change

Add a note section in Production Readiness Checklist on flink security

Brief change log

just a doc update

Verifying this change

validate markdown file is rendered properly

Does this pull request potentially affect one of the following parts:

N/A

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 13, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

### Secure Flink Cluster Access

To prevent potential security vulnerabilities, such as arbitrary code execution, ensure that your Flink clusters are only accessible to trusted users. Flink clusters should not be exposed to the company intranet or public internet. For more details, refer to the [Flink Security FAQ](https://flink.apache.org/what-is-flink/security/#during-a-security-analysis-of-flink-i-noticed-that-flink-allows-for-remote-code-execution-is-this-an-issue).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems very restrictive to say Flink clusters should not be exposed to the company intranet. If they are locked down with TLS and appropriate authentication - this could be acceptable, rather than having to have its own network to run Flink. We could have a statement around TLS and better still mTLS for all connections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davidradl.

i have incorporated your suggestion. Please review whenever time

@davidradl
Copy link
Contributor

Reviewed by Chi on 12/12/24. Asked submitter questions

@Samrat002 Samrat002 requested a review from davidradl December 16, 2024 08:44
@Samrat002
Copy link
Contributor Author

@rmetzger Please review whenever time

### Secure Flink Cluster Access

To prevent potential security vulnerabilities, such as arbitrary code execution,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the language here can be more explicit. Arbitrary code execution is not a potential vulnerability.
Flink has been designed for arbitrary, remote code execution -- it is not an accident ;)
Check also this FAQ entry for how we've worded this in the past: https://flink.apache.org/what-is-flink/security/#during-a-security-analysis-of-flink-i-noticed-that-flink-allows-for-remote-code-execution-is-this-an-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants