Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) #25794

Open
wants to merge 1 commit into
base: release-1.20
Choose a base branch
from

Conversation

mehdid93
Copy link
Contributor

Contribute-to: https://issues.apache.org/jira/browse/FLINK-36901

What is the purpose of the change

This pull request raises the version of the NodeJS module which is a pre-requisite to upgrade dependencies in order to address vulnerabilities in Runtime/WebFrontend component.
There will be another PR to fix vulnerabilities once this is merged.

Brief change log

NodeJS is v22.11.0/Npm is 10.9.0

Verifying this change

The Flink UI should be accessible without any difference

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@mehdid93 mehdid93 changed the title [FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [BP][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) Dec 13, 2024
@mehdid93 mehdid93 changed the title [BP][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) Dec 13, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Dec 13, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@rmetzger
Copy link
Contributor

Looks like the build failure is related to this PR:

16:06:30.274 [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.1:npm (npm install) on project flink-runtime-web: Failed to run task: 'npm ci --cache-max=0 --no-save ${npm.proxy}' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants