[FLINK-36941][docs] Update DATE_FORMAT Doc and Python Tests in 1.20 #25874
+30
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To update the documentation for
DATE_FORMAT
, which is not accurate now. The current function behaviors are:DATE_FORMAT(timestamp, string)
eventually callsformatTimestamp(TimestampData ts, String format, ZoneId zoneId)
inDateTimeUtils.java
, which uses DateTimeFormatter.DATE_FORMAT(string, string)
eventually callsformatTimestampStringWithOffset(String dateStr, String fromFormat, String toFormat, TimeZone tz, long offsetMills)
inDateTimeUtils.java
, which uses SimpleDateFormat.Per this comment, we will fix documentation in Flink 1.20.
https://github.com/apache/flink/pull/25828/files#r1894021871
Brief change log
DATE_FORMAT
.DATE_FORMAT
functions.Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
Added python tests for for specific
DATE_FORMAT
functions.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation