Skip to content

[FLINK-36994][table] Support ALTER MATERIALIZED TABLE As <Query> statement #25880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2025
Merged

[FLINK-36994][table] Support ALTER MATERIALIZED TABLE As <Query> statement #25880

merged 4 commits into from
Jan 9, 2025

Conversation

hackergin
Copy link
Contributor

What is the purpose of the change

Add support query modification for materialized table

Brief change log

**

  • Add support parse materialized table query modification statements
  • Add support convert materialized table node to operation
  • Add support execution of query modification of materialized table

Verifying this change

Some unit test and ITCase will be added in MaterializedTableStatementITCase to verify these changes.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (Will be added in a separated pr)

@hackergin hackergin changed the title Drat: [FLIP-492] Support query modification for materialized table Draft: [FLIP-492] Support query modification for materialized table Jan 2, 2025
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 2, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

lsyldliu
lsyldliu reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackergin Thanks for your contribution, I left some comments.

lsyldliu
lsyldliu reviewed Jan 3, 2025
View reviewed changes
.../apache/flink/table/operations/materializedtable/AlterMaterializedTableAsQueryOperation.java Outdated
}
}
for (int i = oldSchema.getColumns().size(); i < newSchema.getColumns().size(); i++) {
Column newColumn = newSchema.getColumns().get(i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the new added column is duplicated with old column, what behavior is? I think you should a test case to verify it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my testing, if duplicate field names appear in a query, the latter field names will automatically have suffixes added, which seems consistent with the logic of the Calcite framework. For example, if there are two fields named a, the second a will automatically be renamed to a0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the implementation of CreateView, and it does include validation for field name conflicts. We can reuse this logic.

flink/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConvertUtils.java

Line 144 in 75c26e8

private static void validateDuplicatedColumnNames(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help create a jira issue to track it? I think we should forbid the duplicated name case.

@hackergin hackergin changed the title Draft: [FLIP-492] Support query modification for materialized table [FLINK-36993][table] Support ALTER MATERIALIZED TABLE As <Query> statement Jan 5, 2025
@hackergin hackergin force-pushed the FLIP-492-poc branch 2 times, most recently from 90c372c to a204971 Compare January 6, 2025 03:14
@hackergin hackergin changed the title [FLINK-36993][table] Support ALTER MATERIALIZED TABLE As <Query> statement [FLINK-36994][table] Support ALTER MATERIALIZED TABLE As <Query> statement Jan 6, 2025
lsyldliu
lsyldliu reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, I left some comments.

@hackergin hackergin force-pushed the FLIP-492-poc branch 2 times, most recently from e11351a to 74b9f83 Compare January 8, 2025 06:20
lsyldliu
lsyldliu reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackergin Thanks for updating, LGTM overall, just left some minor comments. BTW, can you help rebase the master branch?

lsyldliu
lsyldliu reviewed Jan 8, 2025
View reviewed changes
.../java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java Outdated

throw new SqlExecutionException(
String.format(
"Failed to alter materialized table as query operation for materialized table %s.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Failed to alter materialized table as query operation for materialized table %s.",
"Failed to restore the continuous refresh job using original query {} when altering materialized table {} select query failure.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I understand that it’s not about resuming the failure of the original task, but rather failing to start with a new query, keeping it consistent with the above log.warn()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I think we can print the log only before throw the exception, it makes me a mistake.

lsyldliu
lsyldliu approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsyldliu lsyldliu merged commit 5e0e5a2 into apache:master Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsyldliu lsyldliu lsyldliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hackergin @flinkbot @lsyldliu