Skip to content

[FLINK-38044][runtime-web] update angular to v20 #26805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Laffery
Copy link
Contributor

@Laffery Laffery commented Jul 17, 2025

What is the purpose of the change

Angular framework and NG-ZORRO both have released their stable v19 versions. It is a good time to bump them to the latest.

Brief change log

  • update frontend framework angular and ng-zorro-antd to v20
  • migrate angular builder to application (which is default since v19)
  • remove redundant standalone:true (which is default since v19)
  • remove deprecated APIs in ng-zorro-antd v20
  • move utility function typeDefinition to public-api

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@Laffery Laffery changed the title Chore/angular v20 [FLINK-38044][runtime-web] update angular to v20 Jul 17, 2025
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 17, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@davidradl
Copy link
Contributor

@Laffery Thanks for this update. I notice the CI is failing with errors that seems related to the change.
Unsupported engine {
09:47:19.352 [INFO] npm warn EBADENGINE package: '@angular-devkit/[email protected]',
09:47:19.352 [INFO] npm warn EBADENGINE required: {
09:47:19.352 [INFO] npm warn EBADENGINE node: '^20.19.0 || ^22.12.0 || >=24.0.0',
09:47:19.352 [INFO] npm warn EBADENGINE npm: '^6.11.0 || ^7.5.6 || >=8.0.0',
09:47:19.352 [INFO] npm warn EBADENGINE yarn: '>= 1.13.0'
09:47:19.352 [INFO] npm warn EBADENGINE },

@Laffery
Copy link
Contributor Author

Laffery commented Jul 17, 2025

@davidradl Oh yes the supported node version of angular v20 had changed to ^20.19.0 || ^22.12.0 || >=24.0.0 and the current version of nodejs is v22.11.0

I just pushed a commit to update the version of nodejs to the latest v22 LTS v22.16.0

@Laffery
Copy link
Contributor Author

Laffery commented Jul 17, 2025

@flinkbot run azure

@Laffery
Copy link
Contributor Author

Laffery commented Jul 23, 2025

hi @davidradl, I had fix the issues mentioned, could you please take a look again on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants