[metric] Add cluster_id tag for client metric group #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiebingYu
changed the title
| new ClientMetricGroup( | ||
| metricRegistry, | ||
| ServerMetricUtils.validateAndGetClusterId(conf), | ||
| SERVER_NAME + "-" + serverId); |
There was a problem hiding this comment.
It seems more like server_id rather than cluster_id? Different server in same cluster will collect different viriable.
There was a problem hiding this comment.
It seems more like
server_idrather thancluster_id? Different server in same cluster will collect different viriable.
server_id has already been added. Here I want to add cluster_id for client metric. The cluster_id is necessary when troubleshooting issues, for example, when examining metrics related to requests sent by the ReplicaFetcherThread. Currently, since the client metrics do not have a cluster_id label, we are unable to distinguish metrics from different clusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1652
Brief change log
Tests
API and Format
Documentation