This repository was archived by the owner on Oct 30, 2023. It is now read-only.
Improve performance of LongByteMappingStore #91
+52
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the overhead comes from using an atomicinteger that's written to for every entry addition. I don't see any particular value in this keeping this counter, which incurs high overhead is it is accessed on every entry. There are better ways to update it as values are added, if we think this is useful, we can add it then.
Modified also the getByteTarget method to do one less hashmap access as per the comment by @spupyrev .
Tests
https://issues.apache.org/jira/browse/GIRAPH-1210