-
Notifications
You must be signed in to change notification settings - Fork 400
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
### What changes were proposed in this pull request? This PR proposes to add tag support for columns. ### Why are the changes needed? With this PR, user could add and remove tags in the column level. Fix: #4599 Fix: #4809 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add new UT and IT to test. --------- Co-authored-by: Qi Yu <[email protected]>
- Loading branch information
Showing
28 changed files
with
929 additions
and
145 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
api/src/test/java/org/apache/gravitino/TestMetadataObjects.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.gravitino; | ||
|
|
||
| import com.google.common.collect.Lists; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TestMetadataObjects { | ||
|
|
||
| @Test | ||
| public void testColumnObject() { | ||
| MetadataObject columnObject = | ||
| MetadataObjects.of("catalog.schema.table", "c1", MetadataObject.Type.COLUMN); | ||
| Assertions.assertEquals("catalog.schema.table", columnObject.parent()); | ||
| Assertions.assertEquals("c1", columnObject.name()); | ||
| Assertions.assertEquals(MetadataObject.Type.COLUMN, columnObject.type()); | ||
| Assertions.assertEquals("catalog.schema.table.c1", columnObject.fullName()); | ||
|
|
||
| MetadataObject columnObject2 = | ||
| MetadataObjects.of( | ||
| Lists.newArrayList("catalog", "schema", "table", "c2"), MetadataObject.Type.COLUMN); | ||
| Assertions.assertEquals("catalog.schema.table", columnObject2.parent()); | ||
| Assertions.assertEquals("c2", columnObject2.name()); | ||
| Assertions.assertEquals(MetadataObject.Type.COLUMN, columnObject2.type()); | ||
| Assertions.assertEquals("catalog.schema.table.c2", columnObject2.fullName()); | ||
|
|
||
| MetadataObject columnObject3 = | ||
| MetadataObjects.parse("catalog.schema.table.c3", MetadataObject.Type.COLUMN); | ||
| Assertions.assertEquals("catalog.schema.table", columnObject3.parent()); | ||
| Assertions.assertEquals("c3", columnObject3.name()); | ||
| Assertions.assertEquals(MetadataObject.Type.COLUMN, columnObject3.type()); | ||
| Assertions.assertEquals("catalog.schema.table.c3", columnObject3.fullName()); | ||
|
|
||
| // Test parent | ||
| MetadataObject parent = MetadataObjects.parent(columnObject); | ||
| Assertions.assertEquals("catalog.schema.table", parent.fullName()); | ||
| Assertions.assertEquals("catalog.schema", parent.parent()); | ||
| Assertions.assertEquals("table", parent.name()); | ||
| Assertions.assertEquals(MetadataObject.Type.TABLE, parent.type()); | ||
|
|
||
| // Test incomplete name | ||
| Assertions.assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> MetadataObjects.parse("c1", MetadataObject.Type.COLUMN)); | ||
| Assertions.assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> MetadataObjects.parse("catalog", MetadataObject.Type.COLUMN)); | ||
| Assertions.assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> MetadataObjects.parse("catalog.schema", MetadataObject.Type.COLUMN)); | ||
| Assertions.assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> MetadataObjects.parse("catalog.schema.table", MetadataObject.Type.COLUMN)); | ||
|
|
||
| // Test incomplete name list | ||
| Assertions.assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> MetadataObjects.of(Lists.newArrayList("catalog"), MetadataObject.Type.COLUMN)); | ||
| Assertions.assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> | ||
| MetadataObjects.of( | ||
| Lists.newArrayList("catalog", "schema"), MetadataObject.Type.COLUMN)); | ||
| Assertions.assertThrows( | ||
| IllegalArgumentException.class, | ||
| () -> | ||
| MetadataObjects.of( | ||
| Lists.newArrayList("catalog", "schema", "table"), MetadataObject.Type.COLUMN)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.