[#5051] GravitinoClient needs metalake to obtain version #5060
Conversation
|
Thanks for your contribution. There are a couple of unnecessary changes to the documentation here, can you please fix those? It also looks like you using an old branch, it would be best to use a new branch off the main one. |
Hello, I didn't quite understand what it meant. Can you explain it to me |
|
Your PR include changes to apache-hive-catalog.md and a couple of other .md documentation files, these changes are not related to the issue and should not be in the PR. Your branch is also 3 months out of date, it would be best to base your PR on a newer branch. |
Hello, I am unable to use a specific commit file specified in the submitted PR. Can you help me |
| @@ -537,7 +555,7 @@ public GravitinoClient build() { | |||
| metalakeName != null && !metalakeName.isEmpty(), | |||
| "The argument 'metalakeName' must be a valid name"); | |||
There was a problem hiding this comment.
I think the checks on metalakeName will stop the new constructor from being called if metalake name is null or empty.
| * support the case that the client-side version is higher than the server-side version. | ||
| * @param headers The base header for Gravitino API. | ||
| * @throws NoSuchMetalakeException if the metalake with specified name does not exist. | ||
| */ |
There was a problem hiding this comment.
How is the metalake set after calling this constructor?
There was a problem hiding this comment.
Hello, I will close this PR first and make some modifications. Later, I will open a new PR for further discussion
What changes were proposed in this pull request?
[Improvement] GravitinoClient needs metalake to obtain version
Why are the changes needed?
Fix: #5051
Does this PR introduce any user-facing change?
No