[#5152] fix(oceanbase-catalog): OB catalog UTs failed on Mac #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please fix the style issue @featherchen ? |
|
@jerryshao Sure, but actually the OB catalog UTs will still fail after these changes. |
|
@mchades would you please help on this PR? |
|
you can find the container logs in |
featherchen
force-pushed
the
issue-5152
branch
from
12feb14 to
988a1a3
Compare
|
I see that CI has passed, can you successfully run the OB catalog container tests on your local Mac? |
featherchen
force-pushed
the
issue-5152
branch
from
988a1a3 to
be4e420
Compare
mchades
approved these changes
Oct 21, 2024
mchades
changed the title
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…pache#5178) ### What changes were proposed in this pull request? The max user processes in the OB catalog unit tests should be larger than 120000 ### Why are the changes needed? Fix: apache#5152 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ./gradlew :catalogs:catalog-jdbc-oceanbase:test -PskipDockerTests=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The max user processes in the OB catalog unit tests should be larger than 120000
Why are the changes needed?
Fix: #5152
Does this PR introduce any user-facing change?
No
How was this patch tested?
./gradlew :catalogs:catalog-jdbc-oceanbase:test -PskipDockerTests=false