Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4661] improve(build): Add LICENSE and NOTICE file to jar #5273

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Add LICENSE and NOTICE files to the built jars.

Why are the changes needed?

To meet the requirement.

Fix: #4661

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Local verification.

@jerryshao jerryshao added the branch-0.7 Automatically cherry-pick commit to branch-0.7 label Oct 25, 2024
@jerryshao jerryshao requested a review from yuqi1129 October 25, 2024 11:05
@jerryshao jerryshao self-assigned this Oct 25, 2024
@jerryshao jerryshao marked this pull request as ready for review October 25, 2024 11:05
@jerryshao
Copy link
Contributor Author

@yuqi1129 please help to review this.

@jerryshao jerryshao requested a review from yuqi1129 October 29, 2024 04:11
@jerryshao jerryshao merged commit 80521fd into apache:main Oct 29, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
### What changes were proposed in this pull request?

Add LICENSE and NOTICE files to the built jars.

### Why are the changes needed?

To meet the requirement.

Fix: #4661

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Local verification.
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this pull request Nov 6, 2024
…che#5273)

### What changes were proposed in this pull request?

Add LICENSE and NOTICE files to the built jars.

### Why are the changes needed?

To meet the requirement.

Fix: apache#4661

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Local verification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.7 Automatically cherry-pick commit to branch-0.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] The release jar should contains LICENSE and NOTICE
2 participants