[#4582] fix(hadoop-catalog): Fix some location without slash issue #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaofengshi @xloya @yuqi1129 please help to review this PR. |
jerryshao
changed the title
|
I think we should also add some checks when creating a catalog / schema with a location to force the user to input the correct location, WDYT? |
|
I think we can, previously, I postponed this to the fileset creation. Let me think a bit on this. Maybe we can have a simple fix here and do a thorough fix in the next version? |
|
LGTM. |
yuqi1129
approved these changes
Oct 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…5296) ### What changes were proposed in this pull request? Add the trailing slash to avoid issues when user set illegal location to catalog and schema. For example, if user set "hdfs://ip:port" as a catalog or schema location, we need to add a trailing "/" to avoid issues in creating a `Path`. ### Why are the changes needed? Users can set Catalog and schema "location" with improper path, like "hdfs://ip:port", to support this case, we need to add an additional slash to the end of the location. Fix: #4582 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a new IT to test.
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…sue (apache#5296) ### What changes were proposed in this pull request? Add the trailing slash to avoid issues when user set illegal location to catalog and schema. For example, if user set "hdfs://ip:port" as a catalog or schema location, we need to add a trailing "/" to avoid issues in creating a `Path`. ### Why are the changes needed? Users can set Catalog and schema "location" with improper path, like "hdfs://ip:port", to support this case, we need to add an additional slash to the end of the location. Fix: apache#4582 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a new IT to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the trailing slash to avoid issues when user set illegal location to catalog and schema. For example, if user set "hdfs://ip:port" as a catalog or schema location, we need to add a trailing "/" to avoid issues in creating a
Path.Why are the changes needed?
Users can set Catalog and schema "location" with improper path, like "hdfs://ip:port", to support this case, we need to add an additional slash to the end of the location.
Fix: #4582
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add a new IT to test.