[#5341] fix (trino-connector): Adjust the default precision of the time and timestamp types for different catalogs #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Oct 31, 2024
| return TimestampType.TIMESTAMP_MICROS; | ||
| } | ||
| } else if (Name.TIME == type.name()) { | ||
| return TimeType.TIME_MICROS; |
There was a problem hiding this comment.
Is the Time type in Trino has micro seconds precision?
There was a problem hiding this comment.
Yes，the default time precision in PG is micro seconds
Comment on lines
40
to
44
| if (timestampType.hasTimeZone()) { | ||
| unsupportedType = true; | ||
| } else if (Type.Name.TIME == type.name()) { | ||
| unsupportedType = true; | ||
| } |
There was a problem hiding this comment.
If (timestampType.hasTimeZone() || Type.Name.TIME == type.name()) {
throw new TrinoException(
GravitinoErrorCode.GRAVITINO_UNSUPPORTED_GRAVITINO_DATATYPE,
"Unsupported gravitino datatype: " + type);
}
yuqi1129
approved these changes
Oct 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
…me and timestamp types for different catalogs (#5368) ### What changes were proposed in this pull request? Adjust the default precision of the time and timestamp types for different catalogs. keep the same precision as the original connector ### Why are the changes needed? Fix: #5341 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Update IT
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…the time and timestamp types for different catalogs (apache#5368) ### What changes were proposed in this pull request? Adjust the default precision of the time and timestamp types for different catalogs. keep the same precision as the original connector ### Why are the changes needed? Fix: apache#5341 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Update IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adjust the default precision of the time and timestamp types for different catalogs. keep the same precision as the original connector
Why are the changes needed?
Fix: #5341
Does this PR introduce any user-facing change?
No
How was this patch tested?
Update IT