-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5383] Add table property commands to Gravitino CLI #5390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clients/cli/README.md # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/CommandEntities.java # clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/OwnerDetails.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetOwner.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestCommandEntities.java # docs/cli.md
…rg.apache.gravitino.CatalogProvider file not needed
shaofengshi
reviewed
Nov 29, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTableProperties.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 29, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTableProperties.java
Show resolved
Hide resolved
…rg.apache.gravitino.CatalogProvider file not needed
Note this is failing due to an unrelated change in catalogs/catalog-lakehouse-paimon |
# Conflicts: # docs/cli.md
add back owner commands
@shaofengshi ready again |
shaofengshi
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added table property commands to Gravitino CLI.
Why are the changes needed?
The expand the CLI support.
Fix: #5383
Does this PR introduce any user-facing change?
No, but it adds more commands.
How was this patch tested?
Tested locally with Hive, Postgres and MySQL databases. Note that database support varies.