[#5498] improvement(storage): Modify the length limit of privileges column #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Nov 7, 2024
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
| -- | ||
| ALTER TABLE role_meta_securable_object ALTER COLUMN privilege_names TYPE VARCHAR(81920); |
There was a problem hiding this comment.
Is there any difference between VARCHAR and TEXT for PG?
There was a problem hiding this comment.
PG can't use TEXT. I try TEXT. It throws an error.
|
You should have a test to cover your fix at least. |
OK, my origin test case leave a privilege. I added it. |
jerryshao
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify the length limit of privileges column
According to the privilege interface, our privilege max value is 64 * 64. Every privilege name is about 14 character. So I use 64* 64 * 20 as new length limit.
Why are the changes needed?
Fix: #5498
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test.