Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5489] fix(build): Improve the gradle to skip some modules to avoid publishing empty jars #5501

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

This PR improves the gradle and release script to skip some modules.

Why are the changes needed?

This is to avoid some unnecessary empty jars to be published to maven repo.

Fix: #5489

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested locally.

@jerryshao jerryshao requested review from yuqi1129 and mchades November 7, 2024 07:29
@jerryshao jerryshao self-assigned this Nov 7, 2024
@jerryshao jerryshao changed the title [#5489]fix(build): Improve the gradle to skip some modules to avoid publishing empty jars [#5489] fix(build): Improve the gradle to skip some modules to avoid publishing empty jars Nov 7, 2024
Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yuqi1129 Do you want to review it?

@mchades
Copy link
Contributor

mchades commented Nov 7, 2024

Does this PR need to be backported to branch-0.7?

@yuqi1129
Copy link
Contributor

yuqi1129 commented Nov 7, 2024

LGTM. @yuqi1129 Do you want to review it?

I'm okay with the changes.

@jerryshao
Copy link
Contributor Author

Let me add the label.

@jerryshao jerryshao added the branch-0.7 Automatically cherry-pick commit to branch-0.7 label Nov 7, 2024
@jerryshao jerryshao requested a review from mchades November 8, 2024 00:38
@mchades mchades merged commit 72b92d6 into apache:main Nov 8, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
…publishing empty jars (#5501)

### What changes were proposed in this pull request?

This PR improves the gradle and release script to skip some modules.

### Why are the changes needed?

This is to avoid some unnecessary empty jars to be published to maven
repo.

Fix: #5489 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.7 Automatically cherry-pick commit to branch-0.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] release binary does not exclude integration-test jars
3 participants